![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 11 years ago
Closed 10 years ago
#985 closed defect (bug) (wontfix)
Download button line-height is off
| Reported by: | nphaskins | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | General | Keywords: | has-patch |
| Cc: |
Description
The second button on wordpress.org, the one that says Download Wordpress 4.1.1, it's line-height is off. I'm viewing this in Chrome, but it's also the same for me in Firefox as well, so it seems like a cross-browser issue.
http://cl.ly/image/1R2f1d101a36
It can be fixed by adjusting the line height to 32px from 28px. This download button has a specific CSS class. I don't see this line height issue anywhere else currently.
Here's the fix:
.col-3 a.download-button {line-height:32px;}
Attachments (1)
Change History (10)
#2
@
11 years ago
Hrm, that's super interesting. It's definitely not as bad in Windows, but seems to be a diff across the two. Few more shots:
Windows 8 running Chrome 41: http://cl.ly/image/3W2R2s0B3S1S
Windows 7 running Chrome 41: http://cl.ly/image/2s2A1c0S2m3l
Yosemite, Chrome 41: http://cl.ly/image/1A2F350W1E21
#3
@
11 years ago
The whole thing on Yosemite seems thicker and bolder. Examine the main menu, the main header, even the serif'd intro text. Must be a font difference somewhere.
Chrome tells me the Download button renders in Arial. What does Yosemite render for the font?
#4
@
11 years ago
On both Win and Mac it's inheriting sans-serif from body. I think what's happening is that the OS is returning a different default.
Those who have Helvetica installed on Macs, get served Helvetica for sans-serif. On PC, users without Helvetica get served is Arial. To test this, do you have Helvetica installed on your Windows box?
P.S - If I force Arial on my Mac, the line-height corrects itself to match that of Windows.
#5
@
11 years ago
Maybe we should specify Arial as the font then, with sans-serif as the fallback, for consistency. I do believe Arial is on Mac by default.
Looks okay to me in Chrome on Windows, but your image looks like it's the wrong font or it's too bold or something. Maybe it's a Mac-specific thing?