Changeset 12477

Timestamp:

03/17/2023 03:48:02 AM (4 years ago)

Author:

dd32

Message:

Plugin Directory: When a plugin has multiple formats of an image asset (svg, png, jpg) prefer them in that order.

See ​https://wordpress.slack.com/archives/C02QB8GMM/p1678987204746449.
See #6627.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-template.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-template.php

@@ -568 +568 @@
                 if ( ! $assets ) {
                         return false;
+                }
+
+                // Sort them if needed, svg > png > jpg
+                if ( count( $assets ) > 1 ) {
+                        uasort( $assets, function( $a, $b ) {
+                                // Thankfully the extensions are alphabetical, so let's just sort by that.
+                                $a_ext = strtolower( pathinfo( $a['filename'], PATHINFO_EXTENSION ) );
+                                $b_ext = strtolower( pathinfo( $b['filename'], PATHINFO_EXTENSION ) );
+
+                                return $b_ext <=> $a_ext;
+                        } );
                 }