Changeset 1952

Timestamp:

10/09/2015 05:43:36 AM (11 years ago)

Author:

drewapicture

Message:

Core Trac: Add the has-unit-tests, has-screenshots and needs-screenshots Trac keywords.

Also adds logic for automagically swapping opposites when added, e.g. Adding has-screenshots removes needs-screenshots, adding has-unit-tests removes needs-unit-tests.

See #1318.

File:

• sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js

@@ -14 +14 @@
                 'ui-feedback' : 'Feedback is needed from the user interface perspective, generally from the UI team.',
                 'ux-feedback' : 'Feedback is needed from the user experience perspective, generally from a UX lead.',
+                'has-unit-tests' : 'Proposed solution has unit test coverage.',
                 'needs-unit-tests' : 'Ticket has a particular need for unit tests.',
                 'needs-docs' : 'Inline documentation is needed.',
                 'needs-codex' : 'The Codex needs to be updated or expanded.',
+                'has-screenshots' : 'Visual changes are documented with screenshots.',
+                'needs-screenshots' : 'Screenshots are needed as a visual change log.',
                 'commit' : 'Patch is a suggested commit candidate.',
                 'early' : 'Ticket should be addressed early in the next dev cycle.',
@@ -538 +541 @@
                                         } else if ( 'needs-patch' === keyword ) {
                                                 wpTrac.workflow.removeKeyword( 'has-patch' );
+                                        }
+
+                                        if ( 'has-unit-tests' === keyword ) {
+                                                wpTrac.workflow.removeKeyword( 'needs-unit-tests' );
+                                        } else if ( 'needs-unit-tests' === keyword ) {
+                                                wpTrac.workflow.removeKeyword( 'has-unit-tests' );
+                                        }
+
+                                        if ( 'has-screenshots' === keyword ) {
+                                                wpTrac.workflow.removeKeyword( 'needs-screenshots' );
+                                        } else if ( 'needs-screenshots' === keyword ) {
+                                                wpTrac.workflow.removeKeyword( 'has-screenshots' );
                                         }