Making WordPress.org

Changeset 1952


Ignore:
Timestamp:
10/09/2015 05:43:36 AM (9 years ago)
Author:
drewapicture
Message:

Core Trac: Add the has-unit-tests, has-screenshots and needs-screenshots Trac keywords.

Also adds logic for automagically swapping opposites when added, e.g. Adding has-screenshots removes needs-screenshots, adding has-unit-tests removes needs-unit-tests.

See #1318.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js

    r1703 r1952  
    1414        'ui-feedback' : 'Feedback is needed from the user interface perspective, generally from the UI team.',
    1515        'ux-feedback' : 'Feedback is needed from the user experience perspective, generally from a UX lead.',
     16        'has-unit-tests' : 'Proposed solution has unit test coverage.',
    1617        'needs-unit-tests' : 'Ticket has a particular need for unit tests.',
    1718        'needs-docs' : 'Inline documentation is needed.',
    1819        'needs-codex' : 'The Codex needs to be updated or expanded.',
     20        'has-screenshots' : 'Visual changes are documented with screenshots.',
     21        'needs-screenshots' : 'Screenshots are needed as a visual change log.',
    1922        'commit' : 'Patch is a suggested commit candidate.',
    2023        'early' : 'Ticket should be addressed early in the next dev cycle.',
     
    538541                    } else if ( 'needs-patch' === keyword ) {
    539542                        wpTrac.workflow.removeKeyword( 'has-patch' );
     543                    }
     544
     545                    if ( 'has-unit-tests' === keyword ) {
     546                        wpTrac.workflow.removeKeyword( 'needs-unit-tests' );
     547                    } else if ( 'needs-unit-tests' === keyword ) {
     548                        wpTrac.workflow.removeKeyword( 'has-unit-tests' );
     549                    }
     550
     551                    if ( 'has-screenshots' === keyword ) {
     552                        wpTrac.workflow.removeKeyword( 'needs-screenshots' );
     553                    } else if ( 'needs-screenshots' === keyword ) {
     554                        wpTrac.workflow.removeKeyword( 'has-screenshots' );
    540555                    }
    541556
Note: See TracChangeset for help on using the changeset viewer.