Changeset 2836 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-tools.php

Timestamp:

03/28/2016 09:01:37 PM (8 years ago)

Author:

obenland

Message:

Plugin Directory: Cache commit access data to avoid multible db calls.

Reduces DB calls on edit.php from 127 to 11.

See #1570, #1571.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-tools.php (modified) (5 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-tools.php

@@ -38 +38 @@
         global $wpdb;
 
-        return $wpdb->get_col( $wpdb->prepare( 'SELECT user FROM `' . PLUGINS_TABLE_PREFIX . 'svn_access' . '` WHERE path = %s', "/{$plugin_slug}" ) );
+        if ( false === ( $committers = wp_cache_get( "{$plugin_slug}_committer", 'wporg-plugins' ) ) ) {
+            $committers = $wpdb->get_col( $wpdb->prepare( 'SELECT user FROM `' . PLUGINS_TABLE_PREFIX . 'svn_access' . '` WHERE path = %s', "/{$plugin_slug}" ) );
+
+            wp_cache_set( "{$plugin_slug}_committer", $committers, 'wporg-plugins' );
+        }
+
+        return $committers;
     }
 
+    /**
+     * Retrieve a list of plugins a specific user has commit to.
+     *
+     * @param int|\WP_User $user The user.
+     * @return array The list of plugins the user has commit to.
+     */
     public static function get_users_write_access_plugins( $user ) {
         global $wpdb;
@@ -50 +62 @@
         }
 
-        $plugins = $wpdb->get_col( $wpdb->prepare( 'SELECT path FROM `' . PLUGINS_TABLE_PREFIX . 'svn_access' . '` WHERE user = %s', $user->user_login ) );
-        $plugins = array_map( function( $plugin ) { return trim( $plugin, '/' ); }, $plugins );
+        if ( false === ( $plugins = wp_cache_get( "{$user->user_login}_committer", 'wporg-plugins' ) ) ) {
+            $plugins = $wpdb->get_col( $wpdb->prepare( 'SELECT path FROM `' . PLUGINS_TABLE_PREFIX . 'svn_access' . '` WHERE user = %s', $user->user_login ) );
+            $plugins = array_map( function( $plugin ) { return trim( $plugin, '/' ); }, $plugins );
+
+            wp_cache_set( "{$user->user_login}_committer", $plugins, 'wporg-plugins' );
+        }
 
         return $plugins;
@@ -77 +93 @@
         $existing_committers = self::get_plugin_committers( $plugin_slug );
         if ( in_array( $user->user_login, $existing_committers, true ) ) {
-            // User already has write access
+            // User already has write access.
             return true;
         }
+
+        wp_cache_delete( "{$plugin_slug}_committer", 'wporg-plugins' );
+        wp_cache_delete( "{$user->user_login}_committer", 'wporg-plugins' );
 
         return (bool) $wpdb->insert(
@@ -86 +105 @@
                 'path'   => "/{$plugin_slug}",
                 'user'   => $user->user_login,
-                'access' => 'rw'
+                'access' => 'rw',
             )
         );
@@ -109 +128 @@
         }
 
+        wp_cache_delete( "{$plugin_slug}_committer", 'wporg-plugins' );
+        wp_cache_delete( "{$user->user_login}_committer", 'wporg-plugins' );
+
         return $wpdb->delete(
             PLUGINS_TABLE_PREFIX . 'svn_access',