Changeset 3792 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-template.php

Timestamp:

08/09/2016 08:20:56 PM (9 years ago)

Author:

obenland

Message:

Plugin Directory: Accessibility improvements.

Adds more context to ambiguous UI items on front page and single plugin page.

Fixes #1862.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-template.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-template.php

@@ -91 +91 @@
         $num_ratings = array_sum( $ratings );
 
-        return '<div class="plugin-rating" itemprop="aggregateRating" itemscope itemtype="http://schema.org/AggregateRating">' .
-               '<meta itemprop="ratingCount" content="' . esc_attr( $num_ratings ) . '"/>' .
-               '<meta itemprop="ratingValue" content="' . esc_attr( $rating ) . '"/>' .
-               Template::dashicons_stars( $rating ) .
-               '<span class="rating-count">(' . esc_html( $num_ratings ) . ')</span>' .
-               '</div>';
+        return
+            '<div class="plugin-rating" itemprop="aggregateRating" itemscope itemtype="http://schema.org/AggregateRating">' .
+                '<meta itemprop="ratingCount" content="' . esc_attr( $num_ratings ) . '"/>' .
+                '<meta itemprop="ratingValue" content="' . esc_attr( $rating ) . '"/>' .
+                Template::dashicons_stars( $rating ) .
+                /* translators: 1: number of ratings */
+                '<span class="rating-count">(' . sprintf( __( '%1$s <span class="screen-reader-text">total ratings</span>' ), esc_html( $num_ratings ) ) . ')</span>' .
+            '</div>';
     }
 
@@ -410 +412 @@
         $title          = sprintf( $title_template, $rating );
 
-        $output  = '<div class="wporg-ratings" title="' . esc_attr( $title ) . '" data-title-template="' . esc_attr( $title_template ) . '" data-rating="' . esc_attr( $rating ) . '" style="color:#ffb900;">';
+        $output  = '<div class="wporg-ratings" aria-label="' . esc_attr( $title ) . '" data-title-template="' . esc_attr( $title_template ) . '" data-rating="' . esc_attr( $rating ) . '" style="color:#ffb900;">';
         $counter = round( $rating * 2 );
         for ( $i = 1; $i <= 5; $i++ ) {