Changeset 3835

Timestamp:

08/22/2016 04:34:00 PM (5 years ago)

Author:

iandunn

Message:

WordCamp Coming Soon Page: Fix broken menu link.

This bug didn't exist in the original patch, but was introduced during the review phase, because I didn't connect the dots between register_settings_pages() and get_customizer_section_url(), and thought it'd be better to use an absolute URL.

The bug didn't show up during local testing because of differences between the nginx configuration on my sandbox and the config on production, and I failed to test production after deploying.

This commit reverts it back to a relative URL so that it will work again, and also moves it inside register_settings_pages() to avoid confusing it with a complete URL that would be safe to use in other contexts.

See #334
Props ryelle

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-coming-soon-page/classes/wccsp-settings.php (modified) (3 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-coming-soon-page/classes/wccsp-settings.php

@@ -51 +51 @@
 
     /**
-     * Get the URL for the Coming Soon section in the Customizer
-     *
-     * @return string
-     */
-    public function get_customizer_section_url() {
-        $url = add_query_arg(
-            array(
-                'autofocus[section]' => 'wccsp_live_preview',
-                'url'                => rawurlencode( add_query_arg( 'wccsp-preview', '', site_url() ) ),
-            ),
-            admin_url( 'customize.php' )
-        );
-
-        return $url;
-    }
-
-    /**
      * Add a link to the Settings menu
      *
@@ -74 +57 @@
      */
     public function register_settings_pages() {
+        $menu_slug = add_query_arg(
+            array(
+                'autofocus[section]' => 'wccsp_live_preview',
+                'url'                => rawurlencode( add_query_arg( 'wccsp-preview', '', site_url() ) ),
+            ),
+            '/customize.php'
+        );
+
         add_submenu_page(
             'options-general.php',
@@ -79 +70 @@
             __( 'Coming Soon', 'wordcamporg' ),
             self::REQUIRED_CAPABILITY,
-            $this->get_customizer_section_url()
+            $menu_slug
         );
     }