Changeset 3836

Timestamp:

08/22/2016 04:53:17 PM (5 years ago)

Author:

iandunn

Message:

WordCamp Coming Soon Page: Revert font to Open Sans.

The original design used Open Sans, but during the merge I switched to the new 4.6 font stack, because I assumed the new stack could be (and should be) used to replace Open Sans in all contexts. Using native fonts would have avoided all of the problems associated with Open Sans (extra HTTP request, leaking information via headers, etc).

That assumption was incorrect, though, because the new font stack is only meant to be used for UI elements, not content.

See #334
Props ryelle

Location:

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-coming-soon-page

Files:

• classes/wordcamp-coming-soon-page.php (modified) (1 diff)
• css/template-coming-soon.css (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-coming-soon-page/classes/wordcamp-coming-soon-page.php

@@ -47 +47 @@
         $this->dequeue_all_stylesheets();
 
+        wp_register_style(
+            'open-sans',
+            'https://fonts.googleapis.com/css?family=Open+Sans:300italic,400italic,600italic,300,400,600',
+            array(),
+            null
+        );
+
         wp_enqueue_style(
             'wccsp-template',
             plugins_url( '/css/template-coming-soon.css', __DIR__ ),
-            array(),
+            array( 'open-sans' ),
             1
         );

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-coming-soon-page/css/template-coming-soon.css

@@ -1 +1 @@
 body {
     margin: 0;
-    font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif;
+    font-family: "Open Sans", sans-serif;
     font-size: 24px;
     -webkit-font-smoothing: antialiased;