Changeset 3915

Timestamp:

09/01/2016 07:11:12 PM (5 years ago)

Author:

coffee2code

Message:

Profiles Activity Handler: Improve WordCamp-related action strings.

• Add "on".
• For consistency, make attendee branch match string handling of the organizer branch.

Props SergeyBiryukov.
Fixes #1949.

File:

• sites/trunk/profiles.wordpress.org/public_html/wp-content/plugins/wporg-profiles-activity-handler/wporg-profiles-activity-handler.php (modified) (2 diffs)

sites/trunk/profiles.wordpress.org/public_html/wp-content/plugins/wporg-profiles-activity-handler/wporg-profiles-activity-handler.php

@@ -523 +523 @@
                 if ( isset( $_POST['wordcamp_date'] ) && ! empty( $_POST['wordcamp_date'] ) ) {
                     $action = sprintf(
-                        'Joined the organizing team for <a href="%s">%s</a> coming up %s',
+                        'Joined the organizing team for <a href="%s">%s</a> coming up on %s',
                         esc_url( $_POST['url'] ),
                         $_POST['wordcamp_name'],
@@ -541 +541 @@
                     $type = 'wordcamp_attendee_add';
 
-                    $action = sprintf(
-                        'Registered to attend <a href="%s">%s</a>',
-                        esc_url( $_POST['url'] ),
-                        $_POST['wordcamp_name']
-                    );
-
                     if ( isset( $_POST['wordcamp_date'] ) && ! empty( $_POST['wordcamp_date'] ) ) {
-                        $action .= ' ' . sprintf( 'coming up %s', $_POST['wordcamp_date'] );
+                        $action = sprintf(
+                            'Registered to attend <a href="%s">%s</a> coming up on %s',
+                            esc_url( $_POST['url'] ),
+                            $_POST['wordcamp_name'],
+                            $_POST['wordcamp_date']
+                        );
+                    } else {
+                        $action = sprintf(
+                            'Registered to attend <a href="%s">%s</a>',
+                            esc_url( $_POST['url'] ),
+                            $_POST['wordcamp_name']
+                        );
                     }
                 } elseif ( 'attendee_checked_in' == $_POST['activity_type'] ) {