Changeset 4276 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-capabilities.php

Timestamp:

10/20/2016 04:07:33 AM (10 years ago)

Author:

pento

Message:

Plugin directory: Fix a PHP warning introduced in [4260].

The return value of get_the_terms() needs to be tested to ensure it's an array.

See #2111.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-capabilities.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-capabilities.php

@@ -61 +61 @@
                                 if ( ! $plugin_edit_cap ) {
                                         // Contributors can view, but not edit.
-                                        $contributors = (array) wp_list_pluck( get_the_terms( $post, 'plugin_contributors' ), 'name' );
-                                        if ( in_array( $user->user_nicename, $contributors, true ) ) {
-                                                $required_caps[] = 'exist'; // All users are allowed to exist, even when they have no role.
-                                                break;
+                                        $terms = get_the_terms( $post, 'plugin_contributors' );
+                                        if ( is_array( $terms ) ) {
+                                                $contributors = (array) wp_list_pluck( $terms, 'name' );
+                                                if ( in_array( $user->user_nicename, $contributors, true ) ) {
+                                                        $required_caps[] = 'exist'; // All users are allowed to exist, even when they have no role.
+                                                        break;
+                                                }
                                         }
                                 }