Changeset 5235 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-svn-watcher.php

Timestamp:

04/04/2017 06:02:37 AM (7 years ago)

Author:

dd32

Message:

Plugin Directory: SVN Watcher: Don't re-register cron jobs on the init hook as it's too race-condititiony under load with Cavalcade.
Instead add a cron job to check the cronjobs are registered correctly, with a single event set to re-add svn watcher jobs when we know it's going to be marked as failed.

See #2678

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-svn-watcher.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-svn-watcher.php

@@ -73 +73 @@
                 // Set it again, so if the next request fails, this exception will be thrown again, until the issue is resolved.
                 wp_cache_set( 'get_plugin_changes_between_failed', time(), 'svn-watch', 60 );
+
+                // Check the status of the cronjobs are sane, as the exception will trigger it to be marked as `failed`.
+                wp_schedule_single_event( time() + 30, 'plugin_directory_check_cronjobs' );
 
                 throw new Exception( "Could not fetch plugins.svn logs: " . implode( ', ', $logs['errors'] ) );
@@ -162 +165 @@
         $log = SVN::log( self::SVN_URL, 'HEAD' );
         if ( $log['errors'] || ! $log['log'] ) {
+            // Check the status of the cronjobs are sane, as the exception will trigger it to be marked as `failed`.
+            wp_schedule_single_event( time() + 30, 'plugin_directory_check_cronjobs' );
+
             throw new Exception( "Unable to determine HEAD revision" );
         }