Changeset 5716

Timestamp:

07/26/2017 12:45:49 AM (7 years ago)

Author:

tellyworth

Message:

Plugin directory: ask for confirmation before removing a committer. Props @Nikschavan

Fixes #2800

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets

Files:

• class-committers.php (modified) (1 diff)
• js/committers.js (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/class-committers.php

@@ -37 +37 @@
             wp_enqueue_script( 'wporg-plugins-committers', plugins_url( 'js/committers.js', __FILE__ ), array( 'wp-util' ), true );
             wp_localize_script( 'wporg-plugins-committers', 'committersWidget', array(
-                'restUrl'    => get_rest_url(),
-                'restNonce'  => wp_create_nonce( 'wp_rest' ),
-                'pluginSlug' => $post->post_name,
+                'restUrl'            => get_rest_url(),
+                'restNonce'          => wp_create_nonce( 'wp_rest' ),
+                'pluginSlug'         => $post->post_name,
+                'removeCommitterAYS' => __( 'Are you sure you want to remove this committer?', 'wporg-plugins' ),
             ) );
         }

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/js/committers.js

@@ -19 +19 @@
         $( '#committer-list' )
             .on( 'click', '.remove', function() {
+                if ( ! window.confirm( pluginDir.removeCommitterAYS ) ) {
+                    return;
+                }
+
                 var $row = $( this ).addClass( 'spinner' ).parents( 'li' ),
                     url = pluginDir.restUrl + 'plugins/v1/plugin/' + pluginDir.pluginSlug + '/committers/' + $row.data( 'user' ) + '/?_wpnonce=' + pluginDir.restNonce;