Changeset 6230

Timestamp:

12/04/2017 05:17:46 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Plugin Directory: Show an auto-generated icon for closed plugins instead of an empty block, to preserve consistent layout.

See #2627.

Location:

sites/trunk/wordpress.org/public_html/wp-content

Files:

• plugins/plugin-directory/class-template.php (modified) (2 diffs)
• themes/pub/wporg-plugins/template-parts/plugin-single.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-template.php

@@ -360 +360 @@
 
         $icon = $icon_2x = $svg = $generated = false;
+
         foreach ( $raw_icons as $file => $info ) {
             switch ( $info['resolution'] ) {
@@ -387 +388 @@
         }
 
-        if ( ! $icon ) {
+        if ( ! $icon || 'publish' !== $plugin->post_status ) {
             $generated = true;
 

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/template-parts/plugin-single.php

@@ -60 +60 @@
                     default:
                     case 'closed':
-                        $message        = __( 'This plugin has been closed and is no longer available for download.', 'wporg-plugins' );
+                        $message = __( 'This plugin has been closed and is no longer available for download.', 'wporg-plugins' );
                         break;
                 }
@@ -84 +84 @@
 
         <div class="entry-thumbnail">
-            <?php
-            // Don't show the icon for closed plugins
-            if ( ! in_array( $status, array( 'closed', 'disabled' ) ) ) {
-                echo Template::get_plugin_icon( get_post(), 'html' );
-            }
-            ?>
+            <?php echo Template::get_plugin_icon( get_post(), 'html' ); ?>
         </div>