WordPress.org

Making WordPress.org

Opened 9 months ago

Closed 11 days ago

Last modified 8 days ago

#2627 closed enhancement (fixed)

Closed plugins should still have a public page

Reported by: tellyworth Owned by: SergeyBiryukov
Milestone: Plugin Directory v3.0 Priority: high
Component: Plugin Directory Keywords: ui-feedback has-patch dev-feedback
Cc:

Description

Currently, closed/disabled plugins show a 404 error page for regular users.

It would be better to have at least a minimal public page for historical context. Perhaps with download links etc disabled.

Attachments (10)

2627-make-disabled-page-visible.diff (1.2 KB) - added by tellyworth 9 months ago.
Make closed plugins visible from its slug page only.
2627-theme-disable-download-button.diff (1.0 KB) - added by tellyworth 9 months ago.
Disable the download button for public users on closed plugin pages.
2627-add-noindex-meta.patch (4.7 KB) - added by jipmoors 6 months ago.
Adding meta robots noindex to disabled plugin page
2627-add-noindex-meta.2.patch (5.8 KB) - added by tellyworth 6 weeks ago.
Screen Shot 2017-11-02 at 6.58.27 pm.png (149.8 KB) - added by tellyworth 6 weeks ago.
9051082C-4B10-4184-8694-1439ABE026FF.jpeg (165.8 KB) - added by Ipstenu 4 weeks ago.
Proposed design
Description.png (115.0 KB) - added by Ipstenu 4 weeks ago.
Sample Description Page
Development.png (102.9 KB) - added by Ipstenu 4 weeks ago.
Sample Development Page
closed-plugins-template.patch (6.1 KB) - added by joostdevalk 11 days ago.
Fixes the plugin template for closed and disabled plugins
closed-plugins-template-2.patch (7.4 KB) - added by joostdevalk 11 days ago.
Version 2 of the template

Download all attachments as: .zip

Change History (40)

@tellyworth
9 months ago

Make closed plugins visible from its slug page only.

@tellyworth
9 months ago

Disable the download button for public users on closed plugin pages.

#1 @tellyworth
9 months ago

  • Keywords has-patch added

The two initial patches give a minimal implementation to start with.

Closed (disabled) plugins are visible from the slug page - https://wordpress.org/plugins/wpclef/ for example. They don't appear in search results or other list contexts.

The theme patch hides the Download button on closed plugins. There are probably other things that should be disabled or hidden, and the message should be better - perhaps "This plugin has been closed and is no longer available for download."

#2 @Ipstenu
9 months ago

Historically disabled and closed plugins have not been displayed because they're usually done so for pejorative reasons.

Ill or nill, unless we're documenting WHY things are closed, I don't think it's wise to show closed plugins except to say "This plugin is closed..." as it would just cause the same FUD we have today (which I don't like, and yes, I'd like us to tackle in phase 2 :D )

Instead of showing the readme, I would recommend we display a simple message.

Closed: This plugin has been closed and is no longer available for download.

Disabled: This plugin has been closed for new installs.

In both cases for owner/admin: If you did not request this change, please contact plugins@… for a status. All developers with commit access are contacted when a plugin is closed, with the reasons why, so check your spam email too.

Then we can start considering how to properly flag things as 'closed by developer request' and 'closed for guideline infraction' (though I don't want to dog-shame developers and publicize their mistakes if I can help it...)

This ticket was mentioned in Slack in #meta by tellyworth. View the logs.


9 months ago

@jipmoors
6 months ago

Adding meta robots noindex to disabled plugin page

#4 @jipmoors
6 months ago

My new patch is doing the following:

  • refreshing the template file
  • removing JSON LD
  • adding meta robots: noindex to the page

#5 @jipmoors
6 months ago

Related #2860

Last edited 6 months ago by SergeyBiryukov (previous) (diff)

#6 @Ipstenu
6 months ago

FYI #2860 is intended to _eventually_ be incorporated into this, but step one is to record why :) Then I have to figure out how we go back through the thousands of closed plugins and record things properly. Bad data is as useless as no data, after all. That's the phase 2 I mentioned before.

This ticket was mentioned in Slack in #meta by ipstenu. View the logs.


5 months ago

#8 @melchoyce
5 months ago

  • Keywords ui-feedback added

#9 @melchoyce
5 months ago

@tellyworth Can you add some screenshots of your patch?

#10 @SergeyBiryukov
5 months ago

  • Keywords needs-patch added; has-patch removed

The latest patch does not address comment:2.

#11 @Ipstenu
8 weeks ago

@SergeyBiryukov - I think it's okay to push this without tracking why just yet.

That is, we can change it to "This plugin has been removed from the directory and is no longer available for download."

We can go back and enhance it with a separate ticket, but we need to make a step forward :) I'll make a ticket for the follow up of 'Publicly track and disclose WHY a plugin was closed' once we're done with #2860

#12 @SergeyBiryukov
8 weeks ago

  • Milestone set to Plugin Directory v3.0

#13 @tellyworth
6 weeks ago

  • Keywords 2nd-opinion added

This ticket was mentioned in Slack in #meta by ipstenu. View the logs.


6 weeks ago

#15 @tellyworth
6 weeks ago

  • Keywords has-patch added; needs-patch 2nd-opinion removed

#16 @tellyworth
6 weeks ago

  • Keywords dev-feedback added

#17 @SergeyBiryukov
6 weeks ago

  • Owner set to SergeyBiryukov
  • Status changed from new to accepted

#18 @tellyworth
6 weeks ago

attachment:2627-add-noindex-meta.2.patch builds on @jipmoors patch with a couple of improvements:

  • Clearer error message
  • Hides Previous Versions on Advanced page

#19 @Ipstenu
6 weeks ago

:thumbs up emoji:

#20 @SergeyBiryukov
4 weeks ago

In 6118:

Plugin Directory: Allow closed/disabled plugins to have a public page.

  • Add a notice explaining the plugin's current status.
  • Add noindex meta tag.
  • Remove Download button and Previous Versions section.

Props tellyworth, jipmoors, Ipstenu, SergeyBiryukov.
See #2627.

This ticket was mentioned in Slack in #meta by sergey. View the logs.


4 weeks ago

#22 @SergeyBiryukov
4 weeks ago

In 6127:

Plugin Directory: After [6118], allow logged-in users to view closed/disabled plugins as well.

See #2627.

#23 @SergeyBiryukov
4 weeks ago

In 6128:

Plugin Directory: Don't display the locale banner for closed plugins.

See #2627.

@Ipstenu
4 weeks ago

Proposed design

@Ipstenu
4 weeks ago

Sample Description Page

@Ipstenu
4 weeks ago

Sample Development Page

#24 @Ipstenu
4 weeks ago

Using https://wordpress.org/plugins/rickroll/ as an example, I've uploaded two images for examples of a 'better' layout.

Important notes:

1) Support, Reviews, and Advanced View can be left alone for now.

2) In the absence of a readme...
2a) plugin 'name' should be the slug (so yes, "Tap-dancing Demons for WooCommerce" would be woo-tap-demons)
2b) 'author' should be whomever is the owner of the plugin (there's a field for that)

3) Never show the header image or the custom icons

4) CURRENTLY the only things we can show on the status sidebar are "Status: Closed" - the other two need to wait for #2860 :D

The reason we're hiding images and content when possible is that plugins are sometimes closed due to guideline/copyright/content issues regarding readmes and images. If a dev has a plugin closed for injecting spam-links or is using copyright-protected images, we need to hide that for potential legal reasons.

While we can (and will) go in and edit those things for them, I'd rather protect them from themselves from the get-go. Makes for less work for US.

Last edited 4 weeks ago by Ipstenu (previous) (diff)

This ticket was mentioned in Slack in #meta by sergey. View the logs.


3 weeks ago

This ticket was mentioned in Slack in #meta by sergey. View the logs.


2 weeks ago

@joostdevalk
11 days ago

Fixes the plugin template for closed and disabled plugins

@joostdevalk
11 days ago

Version 2 of the template

#27 @Otto42
11 days ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 6225:

Plugins: Modify how the plugin pages look for closed plugins.

  • Display that the plugin was closed and when (if we have that information)
  • Show plugin author a notification box telling them to contact plugins@ if they didn't get an email why
  • Hide most of the content from the readme
  • Don't display the plugin name, just the slug in its place
  • Hide icons, banners, any content from the plugin author
  • Leave space for reasons of closure for future enhancement

Fixes #2627. props @joostdevalk, @otto42

#28 @SergeyBiryukov
10 days ago

In 6230:

Plugin Directory: Show an auto-generated icon for closed plugins instead of an empty block, to preserve consistent layout.

See #2627.

#29 @SergeyBiryukov
10 days ago

In 6232:

Plugin Directory: Remove unnecessary closure in template-parts/plugin-single.php.

See #2627.

This ticket was mentioned in Slack in #meta by sergey. View the logs.


8 days ago

Note: See TracTickets for help on using tickets.