WordPress.org

Making WordPress.org

Opened 4 months ago

Last modified 29 hours ago

#2860 new enhancement

Plugin Admin: Add values for closed plugins

Reported by: Ipstenu Owned by:
Milestone: Plugin Directory v3.0 Priority: normal
Component: Plugin Directory Keywords: has-patch has-screenshots dev-feedback
Cc:

Description

When plugins are closed or disabled, there should be a drop-down selection to list WHY this happened.

  • Security Issue
  • Author Request
  • Guideline Violation
  • Licensing/Trademark violations
  • Merged into Core

Attachments (3)

2860.diff (3.7 KB) - added by jdgrimes 5 weeks ago.
2860.2.diff (4.1 KB) - added by jdgrimes 5 weeks ago.
Also save the reason when disabling a plugin
2860.3.diff (4.5 KB) - added by jdgrimes 5 weeks ago.
Show "Unknown" when close reason is empty

Download all attachments as: .zip

Change History (23)

This ticket was mentioned in Slack in #meta by ipstenu. View the logs.


3 months ago

#2 @zuda
8 weeks ago

  • Keywords 2nd-opinion added
  • Type changed from defect to enhancement

So, I've gone over how this would be the best way done. Since the plugins@… system currently isn't segregated to levels, what could be done is a section of wordpress.org, like admin.plugins.wordpress.org that has all the names of each plugin. You just click the plugin, choose from the dropdown menu what type of issue it is and then a redirect will be put in place informing users what the problem is.

There is a lot of code to be done here, but my company is completely on-board to help.

#3 @Ipstenu
8 weeks ago

At this point the privacy of plugins' email has zero bearing on the situation :)

Plugin STATUS is handled via wordpress.org/plugins/wp-admin :D

#4 @zuda
8 weeks ago

Then if you are already using WordPress as the framework, it would be a lot easier to handle. All needs to be done is grab the plugin names every day or so and auto-update, then have the drop down that changes what is displayed on the page. No manual typing at all.

@jdgrimes
5 weeks ago

#5 @jdgrimes
5 weeks ago

  • Keywords has-patch has-screenshots dev-feedback added; 2nd-opinion removed

2860.diff is an initial patch. It's my first meta patch, so any pointers are welcome.

Before patch:

https://cldup.com/mhLFUaQ3f4.png

With patch (open plugin):

https://cldup.com/KKQgPGegP5.png

With patch (closed plugin):

https://cldup.com/MW1mNa-3zS.png

#6 follow-up: @SergeyBiryukov
5 weeks ago

  • Milestone set to Plugin Directory v3.0

2860.diff looks good at a glance.

The only thing I'd like to add is some JS code to show the dropdown when clicking the Close button (instead of submitting the form), so that closing the plugin and specifying the reason could be done in one go.

#7 in reply to: ↑ 6 ; follow-up: @jdgrimes
5 weeks ago

Replying to SergeyBiryukov:

2860.diff looks good at a glance.

The only thing I'd like to add is some JS code to show the dropdown when clicking the Close button (instead of submitting the form), so that closing the plugin and specifying the reason could be done in one go.

JS can be added to refine the flow, but to be clear, it can already be done in one go. The dropdown is currently just shown all the time. So you can select the reason, and then when the Close button is clicked the form will be submitted and the reason will be saved.

#8 in reply to: ↑ 7 @SergeyBiryukov
5 weeks ago

Replying to jdgrimes:

The dropdown is currently just shown all the time. So you can select the reason, and then when the Close button is clicked the form will be submitted and the reason will be saved.

Ah, great. I misread that part of the patch and was under an impression that the dropdown is only displayed if the plugin is already closed.

#9 @SergeyBiryukov
5 weeks ago

@Ipstenu Is comment:5 what you had in mind? Should the same dropdown be used for disabled plugins as well?

#10 @Ipstenu
5 weeks ago

Yes, the same dropdown should be used on disabled and closed. That would work fine for me :)

@jdgrimes
5 weeks ago

Also save the reason when disabling a plugin

#11 follow-up: @jdgrimes
5 weeks ago

2860.2.diff updates the patch to also save the reason when the Disable button is clicked.

I decided to move the dropdown above the buttons, because it seemed more natural:

Open plugin:

https://cldup.com/zOhwa6cwYe-2000x2000.png

Closed plugin:

https://cldup.com/F_8rFcSrRg.png

Disabled plugin:

https://cldup.com/XvTCzx-tup-2000x2000.png

I thought of one question: should the close/disable reason be deleted when the plugin is opened again? Currently nothing is done at that point, so the reason will continue to be stored in the post meta.

#12 in reply to: ↑ 11 @SergeyBiryukov
5 weeks ago

Replying to jdgrimes:

I decided to move the dropdown above the buttons, because it seemed more natural:

Yeah, that looks better to me as well.

Currently nothing is done at that point, so the reason will continue to be stored in the post meta.

I think it's fine, it might be used for future reference if we ever decide to implement a status change history for a plugin.

@jdgrimes
5 weeks ago

Show "Unknown" when close reason is empty

#13 @jdgrimes
5 weeks ago

2860.3.diff tweaks the previous patch to better handle the case where the close reason isn't known (like if the plugin was closed before the dropdown was added). It will now show "Close Reason: Unknown" instead of just a blank close reason ("Close Reason: ").

https://cldup.com/ZZhgRfwGU2.png

This ticket was mentioned in Slack in #meta by sergey. View the logs.


13 days ago

#15 @Ipstenu
6 days ago

#2404 was marked as a duplicate.

#16 @SergeyBiryukov
45 hours ago

2860.3.diff looks great, the only thing I'd like to add is the ability to specify a reason for previously closed plugins without reopening (by clicking "Save Changes"). Will handle that on commit.

#17 @SergeyBiryukov
44 hours ago

In 6034:

Plugin Directory: Provide the ability to specify a reason when closing or disabling a plugin.

Props jdgrimes.
See #2860.

#18 @SergeyBiryukov
44 hours ago

Remaining item from Slack discussion: decide whether we should also be logging the reason in the internal notes (which still need a date, see #3001). Perhaps that could be done as a part of #2717.

Last edited 44 hours ago by SergeyBiryukov (previous) (diff)

#19 @SergeyBiryukov
42 hours ago

In 6035:

Plugin Directory: Correct the logic for displaying "Close/Disable Reason" dropdown.

See #2860.

#20 @Ipstenu
29 hours ago

An audit log that combined closures (like the dropdown value selected, the date, and by whom) along side the internal notes would be 'best'.

Note: See TracTickets for help on using tickets.