Changeset 6921 for sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/utilities/class-meetup-client.php

Timestamp:

03/24/2018 04:44:22 PM (8 years ago)

Author:

iandunn

Message:

Meetup Client: Retry some requests that result in WP_Errors.

Breaking whenever there's a WP_Error would result in some recoverable errors being given up on, like timeouts.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/utilities/class-meetup-client.php (modified) (2 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/utilities/class-meetup-client.php

@@ -151 +151 @@
      * Wrapper for `wp_remote_get` to retry requests that fail temporarily for various reasons.
      *
+     * One common example of a reason a request would fail, but later succeed, is when the first request times out.
+     *
      * Based on `wcorg_redundant_remote_get`.
      *
@@ -182 +184 @@
             $this->maybe_throttle( wp_remote_retrieve_headers( $response ) );
 
-            if ( in_array( $response_code, $breaking_codes, true ) || is_wp_error( $response ) ) {
+            if ( in_array( $response_code, $breaking_codes, true ) ) {
                 break;
             }