Changeset 7208

Timestamp:

05/14/2018 10:34:09 PM (7 years ago)

Author:

ocean90

Message:

Plugin Directory: In social_meta_data() don't override the 2x banner if it exists as 2x.

See #2303.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/functions.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/functions.php

@@ -274 +274 @@
     $banner = Template::get_plugin_banner();
 
-    $banner['banner_2x'] = $banner['banner_2x'] ? $banner['banner'] : false;
+    $banner['banner']    = $banner['banner'] ?? false;
+    $banner['banner_2x'] = $banner['banner_2x'] ?? false;
 
     printf( '<meta property="og:title" content="%s" />' . "\n", the_title_attribute( array( 'echo' => false ) ) );
@@ -287 +288 @@
         printf( '<meta name="twitter:image" content="%s" />' . "\n", esc_url( $banner['banner_2x'] ) );
     }
-    if ( isset( $banner['banner'] ) ) {
+    if ( $banner['banner'] ) {
         printf( '<meta property="og:image" content="%s" />' . "\n", esc_url( $banner['banner'] ) );
     }