Changeset 7622 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/tools/class-stats-report.php

Timestamp:

08/21/2018 04:56:33 PM (6 years ago)

Author:

Otto42

Message:

Plugins: Stats report - Add output escaping to all printf's. Output in admin areas should always be properly escaped.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/tools/class-stats-report.php (modified) (17 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/tools/class-stats-report.php

@@ -227 +227 @@
             printf(
                 __( 'The day up to which stats are to be gathered. In YYYY-MM-DD format. Defaults to today (%s).', 'wporg-plugins' ),
-                $date
+                esc_html( $date )
             );
         ?>
@@ -270 +270 @@
             printf(
                 __( 'Displaying stats for the %1$d days preceding %2$s (and other stats for the %3$d most recent days).', 'wporg-plugins' ),
-                $stats['num_days'],
-                $stats['date'],
-                $stats['recentdays']
+                esc_html( $stats['num_days'] ),
+                esc_html( $stats['date'] ),
+                esc_html( $stats['recentdays'] )
             );
         ?>
@@ -285 +285 @@
                 printf(
                     __( 'Plugins requested : %d', 'wporg-plugins' ),
-                    $stats['plugin_new']
+                    esc_html( $stats['plugin_new'] )
                 );
             ?>
@@ -294 +294 @@
                 printf(
                     __( 'Plugins rejected : %s', 'wporg-plugins' ),
-                    $stats['plugin_reject']
+                    esc_html( $stats['plugin_reject'] )
                 );
             ?>
@@ -303 +303 @@
                 printf(
                     __( 'Plugins closed : %s', 'wporg-plugins' ),
-                    $stats['plugin_delist']
+                    esc_html( $stats['plugin_delist'] )
                 );
                 $reasons = array();
@@ -321 +321 @@
                 printf(
                     __( 'Plugins approved : %s', 'wporg-plugins' ),
-                    $stats['plugin_approve']
+                    esc_html( $stats['plugin_approve'] )
                 );
             ?>
@@ -335 +335 @@
                 printf(
                     __( 'Plugins in the queue (new and pending)* : %d', 'wporg-plugins' ),
-                    $stats['in_queue']
+                    esc_html( $stats['in_queue'] )
                 );
             ?>
@@ -344 +344 @@
                 printf(
                     __( '→ (older than %1$d days ago)** : %2$d', 'wporg-plugins' ),
-                    $stats['recentdays'],
-                    $stats['in_queue_old']
+                    esc_html( $stats['recentdays'] ),
+                    esc_html( $stats['in_queue_old'] )
                 );
             ?>
@@ -354 +354 @@
                 printf(
                     __( '→ (%1$s - %2$s) : %3$d', 'wporg-plugins' ),
-                    $start_date,
-                    $stats['date'],
-                    $stats['in_queue_from_time_window']
+                    esc_html( $start_date ),
+                    esc_html( $stats['date'] ),
+                    esc_html( $stats['in_queue_from_time_window'] )
                 );
             ?>
@@ -365 +365 @@
                 printf(
                     __( '→ (new; not processed or replied to yet)* : %d', 'wporg-plugins' ),
-                    $stats['in_queue_new']
+                    esc_html( $stats['in_queue_new'] )
                 );
             ?>
@@ -374 +374 @@
                 printf(
                     __( '→ (pending; replied to)* : %d', 'wporg-plugins' ),
-                    $stats['in_queue_pending']
+                    esc_html( $stats['in_queue_pending'] )
                 );
             ?>
@@ -388 +388 @@
                 printf(
                     __( 'Total open tickets* : %d', 'wporg-plugins' ),
-                    $stats['supportpress_queue_total_open']
+                    esc_html( $stats['supportpress_queue_total_open'] )
                 );
             ?>
@@ -397 +397 @@
                 printf(
                     __( ' → (with no activity in last %1$d days)** : %2$d', 'wporg-plugins' ),
-                    $stats['recentdays'],
-                    $stats['supportpress_queue_total_open_old']
+                    esc_html( $stats['recentdays'] ),
+                    esc_html( $stats['supportpress_queue_total_open_old'] )
                 );
             ?>
@@ -407 +407 @@
                 printf(
                     __( 'Within defined %d day time window:', 'wporg-plugins' ),
-                    $stats['num_days']
+                    esc_html( $stats['num_days'] )
                 );
                 ?>
@@ -416 +416 @@
                         printf(
                             __( 'Total : %d', 'wporg-plugins' ),
-                            $stats['supportpress_queue_interval_all']
+                            esc_html( $stats['supportpress_queue_interval_all'] )
                         );
                     ?>
@@ -425 +425 @@
                         printf(
                             __( 'Closed : %d', 'wporg-plugins' ),
-                            $stats['supportpress_queue_interval_closed']
+                            esc_html( $stats['supportpress_queue_interval_closed'] )
                         );
                     ?>
@@ -434 +434 @@
                         printf(
                             __( 'Open : %d', 'wporg-plugins' ),
-                            $stats['supportpress_queue_interval_open']
+                            esc_html( $stats['supportpress_queue_interval_open'] )
                         );
                     ?>