Changeset 8461

Timestamp:

03/14/2019 04:55:02 AM (6 years ago)

Author:

tellyworth

Message:

Plugin directory: fix memory consumption issue in translation sync and re-enable cron job.

$wp_object_cache->group_ops was growing unbounded. Also cleaned up related PHP notices caused by undefined values in stats array.

Fixes #2977

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs

Files:

• class-manager.php (modified) (2 diffs)
• class-translation-sync.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-manager.php

@@ -22 +22 @@
         add_action( 'plugin_directory_svn_sync', array( __NAMESPACE__ . '\SVN_Watcher', 'cron_trigger' ) );
         add_action( 'plugin_directory_update_api_check', array( __NAMESPACE__ . '\API_Update_Updater', 'cron_trigger' ) );
+        add_action( 'plugin_directory_translation_sync', array( __NAMESPACE__ . '\Translation_Sync', 'cron_trigger' ) );
 
         // A cronjob to check cronjobs
@@ -250 +251 @@
             wp_schedule_event( time() + 60, 'every_120s', 'plugin_directory_check_cronjobs' );
         }
+        if ( ! wp_next_scheduled ( 'plugin_directory_translation_sync' ) ) {
+            wp_schedule_event( time() + 60, 'daily', 'plugin_directory_translation_sync' );
+        }
     }
 

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-translation-sync.php

@@ -33 +33 @@
             if ( is_object( $wp_object_cache ) ) {
                 $wp_object_cache->cache = array();
-                $wp_object_cache->stats = array();
+                $wp_object_cache->stats = array( 'add' => 0, 'get' => 0, 'get_multi' => 0, 'delete' => 0);
+                $wp_object_cache->group_ops = array();
             }