WordPress.org

Making WordPress.org

Opened 6 years ago

Closed 4 years ago

Last modified 20 months ago

#105 closed defect (worksforme)

RTL for the Support Forum theme on the international sites

Reported by: RanYanivHartstein Owned by:
Milestone: Priority: low
Component: International Forums Keywords:
Cc:

Description

Migrating from #wp17709:

The RTL styles for the support forums are incomplete. I don't have access to the original files to make a patch, but these fixes should be all that's needed:

#pages a:after, #pages span:after { content: "\200F"; }
#pagebody table.widefat th { text-align: right; }
#pagebody ol#thread { list-style: none; }
#footer iframe, #footer p { float: left; }
#footer h6 { float: right; }

Actually, that first line should be:

#pages a:after, #pages span:after { content: "\200F"; }

Can we get confirmation that this is just a CSS change? If so, we should be able to ship it ASAP.

Change History (6)

#1 @samuelsidler
4 years ago

@ramiy: Can you test this for us to see if there's anything else needed here?

#2 @ramiy
4 years ago

@samuelsidler, I don't have access to the forums. The flowing conclusions are based on chrome inspector:


#pages a:after, #pages span:after { content: "\200F"; }

This is an old trick for RTL (see: http://stackoverflow.com/questions/8227183/rtl-is-on-web-page-reverses-numbers-with-a-dash). Not needed in our case. Seems like ocean90 solved the forum pagination RTL issues when fixed all the rosetta sites RTL issues two months ago.


#pagebody table.widefat th { text-align: right; }

This on is already implemented.


#pagebody ol#thread { list-style: none; }

Needs to be implemented in RTL forums.


#footer iframe, #footer p { float: left; }
#footer h6 { float: right; }

Both #footer are not relevant any more. All footer links removed from rosetta sites in favor of global wporg-footer.

This ticket was mentioned in Slack in #meta-i18n by ramiy. View the logs.


4 years ago

This ticket was mentioned in Slack in #meta by sam. View the logs.


4 years ago

#5 @ocean90
4 years ago

  • Resolution set to worksforme
  • Status changed from new to closed

Seems like none of those styles are needed anymore. Closing as worksforme.

This ticket was mentioned in Slack in #meta by grapplerulrich. View the logs.


20 months ago

Note: See TracTickets for help on using tickets.