WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#1073 closed enhancement (fixed)

WordCamp: Jetpack doesn't use Photon for Gallery images and images using HTTPS

Reported by: jeherve Owned by: iandunn
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: good-first-bug has-patch needs-testing
Cc:

Description

By design, Jetpack only uses Photon for images inserted via HTTP. All HTTPS images will be ignored by Photon.

Since some (all?) of the WordCamp sites now use HTTPS as their site URL, galleries are now built using HTTPS image paths. As a result, the gallery images are resized by the browser, instead of using Photon.

https://s3.amazonaws.com/f.cl.ly/items/2r3S2v0h0N0N0d1H1M09/Screen%20Shot%202015-06-08%20at%2010.30.54%20AM.png
-- See https://lyon.wordcamp.org/2015/les-photos/

To force Jetpack to use Photon anyway, we'd need to use the following filter:

add_filter( 'jetpack_photon_reject_https', '__return_false' );

I'm not sure where you would typically add such a tweak. I don't see any functionality plugin, so in one of the mu-plugins maybe?

Attachments (1)

1073.diff (596 bytes) - added by jeherve 4 years ago.
Force-activate Photon for images served via HTTPS

Download all attachments as: .zip

Change History (7)

#1 @iandunn
4 years ago

In 1663:

Jetpack Tweaks: Consolidate our Jetpack tweaks into a single mu-plugin.

See #1073

#2 @iandunn
4 years ago

  • Keywords needs-patch good-first-bug added
  • Owner set to iandunn
  • Status changed from new to accepted
  • Type changed from defect to enhancement

Yeah, all WordCamp sites are using HTTPS now, on the front-end and back-end.

I consolidated all of our Jetpack tweaks into mu-plugins/jetpack-tweaks.php, so that'd be the best place for this.

@jeherve
4 years ago

Force-activate Photon for images served via HTTPS

#3 @jeherve
4 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

I added a patch. I couldn't test it though, as I'm not sure how to get the whole meta site running locally.

#4 @iandunn
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 1665:

Jetpack Tweaks: Enable Photon support for HTTPS URLs.

Fixes #1073
Props jeherve

#5 @iandunn
4 years ago

Thanks Jeremy, it worked great :)

For future reference, you can setup the Meta Environment to get a copy of WordCamp.org (and other wporg sites) running locally.

#6 @jeherve
4 years ago

Awesome, thanks for the link!

Note: See TracTickets for help on using tickets.