Opened 9 years ago

Closed 9 years ago

#1094 closed defect (bug) (fixed)

Any user authenticated on .org should be able to submit user contributed notes

Reported by: drewapicture's profile DrewAPicture Owned by: coffee2code's profile coffee2code
Milestone: Priority: normal
Component: Developer Hub Keywords: has-patch

Description (last modified by DrewAPicture)

Not sure what was changed, but it appears as though can_user_post_note() when hooked to comments_open makes it only possible to contribute notes when you're authenticated on .org and/or a member of the DevHub site.

Worked this out with @SergeyBiryukov and he should be following up with a patch.

Attachments (1)

meta-1094.patch (3.2 KB) - added by SergeyBiryukov 9 years ago.

Download all attachments as: .zip

Change History (6)

#1 @DrewAPicture
9 years ago

  • Description modified (diff)

#2 @SergeyBiryukov
9 years ago

  • Keywords has-patch added; needs-patch removed

Introduced in [768].

There's a must_log_in string in the comments.php template, but it's not used because the whole block is not displayed if you're not logged in. Looks like DevHub::can_user_post_note() needs to be removed for it to show up.

Last edited 9 years ago by SergeyBiryukov (previous) (diff)

#3 @coffee2code
9 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 1687: Default to allowing user contributed notes from any user.

  • Enable submission of user contributed notes by default.
  • Add redirect_to query arg to login link so that user will be redirected back after logging in.
  • In [10530-dotorg], a restriction via the 'wporg_devhub-can_user_post_note' hook was removed that prevented non-logged in users from seeing the message that they can log in to submit a note.

Fixes #1094.

#4 @SergeyBiryukov
9 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I still get a "Sorry, comments are closed for this item" error when trying to submit a note.

Last edited 9 years ago by SergeyBiryukov (previous) (diff)

#5 @coffee2code
9 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 1689: Remove restriction that user must be member of blog to post user contributed notes.

Fixes #1094.

Note: See TracTickets for help on using tickets.