WordPress.org

Making WordPress.org

Opened 6 years ago

Closed 6 years ago

#114 closed enhancement (wontfix)

Add a wp-org-parent theme that child themes can inherit the global header and footer from.

Reported by: georgestephanis Owned by:
Milestone: Priority: low
Component: General Keywords: has-patch
Cc:

Description

Having this will let folks use a local version like https://github.com/georgestephanis/wp-org-parent to code child themes against, so the code will transition near-seamlessly to wp.org

Attachments (1)

wp-org-parent.diff (2.0 KB) - added by georgestephanis 6 years ago.

Download all attachments as: .zip

Change History (5)

#1 @kpdesign
6 years ago

+1 to this. I had to create a dummy header/footer to run the wporg-P2 theme with handbook plugins locally. This would be so much easier. :)

#2 follow-up: @nacin
6 years ago

This doesn't help too much as most themes are in turn a parent of another theme. For example, wporg-p2 would not be able to be a parent of both P2 and this one. Most helpful would be to actually open-source the header and footer files (which are a mess and have a lot of dependencies).

#3 in reply to: ↑ 2 @georgestephanis
6 years ago

Replying to nacin:

This doesn't help too much as most themes are in turn a parent of another theme. For example, wporg-p2 would not be able to be a parent of both P2 and this one. Most helpful would be to actually open-source the header and footer files (which are a mess and have a lot of dependencies).

This is meant more for subsites, like learn.wordpress.org and the new make.wordpress.org homepage. Hooray, abstraction.

#4 @Otto42
6 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

After looking at this for a while, I actually now agree with nacin. We tend to use child themes for customization of things on org later. And while it's fine to do it as a child for ease-of-development, when we make them live they need to be directly referencing the header/footers instead of being a child themselves.

The meta.svn isn't necessarily a repository where we're making code available for others to use themselves, it's our code that we're using, made public so that we can more easily accept bugfixes on it and such. The use of a parent to make the children less site-dependent is unnecessary because everything in meta.svn is okay to be site-dependent.

Abstraction is nice, but this is a very small abstraction to codify into a parent theme and cause us the grandchild problem later down the road.

Note: See TracTickets for help on using tickets.