WordPress.org
Get WordPress

Making WordPress.org

Opened 9 years ago

Closed 9 years ago

#1252 closed defect (bug) (fixed)

Plugin Directory Screenshots in local RTL view

Reported by: ramiy's profile ramiy Owned by: ocean90's profile ocean90
Milestone: Priority: normal
Component: Plugin Directory Keywords: dev-feedback has-patch commit
Cc:

Description

The hebrew plugin directory (and I guess all the RTL repositories) show the screenshot number - it should be hidden like in the english repo.

See the attached screenshot.

Attachments (2)

plugins-screenshots.png​ (382.4 KB) - added by ramiy 9 years ago.
meta-1252.patch​ (394 bytes) - added by SergeyBiryukov 9 years ago.

Download all attachments as: .zip

Change History (8)

@ramiy
9 years ago

This ticket was mentioned in ​Slack in #meta-i18n by ramiy. ​View the logs.
9 years ago

#2 follow-up: @ocean90
9 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 1921:

wp4.css: Make styling of #pagebody ol consistent in all browsers and languages.

roman isn't a valid value for list-style. WebKit-based browsers render it as none, Firefox as decimal. Additionally the RTL stylesheet had defined decimal. For the sake of consistency it's now set to none.

Fixes #1252.

#3 in reply to: ↑ 2 @ramiy
9 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Change set 1921 hide all the ordered lists.

Seems like the "installation" tabs with ordered lists are affected too. Both LRT and RTL view.

For example: ​https://wordpress.org/plugins/user-switching/installation/

We nee to apply this only on "screenshots" tab.

This ticket was mentioned in ​Slack in #meta-i18n by ramiy. ​View the logs.
9 years ago

@SergeyBiryukov
9 years ago

#5 @SergeyBiryukov
9 years ago

  • Keywords has-patch commit added

#6 @Otto42
9 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 1922:

Fix issue with all ordered list numbers disappearing after [1921]. Fixes #1252. props SergeyBiryukov

Note: See TracTickets for help on using tickets.