WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 3 years ago

#1417 closed enhancement (worksforme)

CSS issue on plugin pages, mobile viewing

Reported by: MrFlannagan Owned by: samuelsidler
Milestone: Priority: normal
Component: Plugin Directory Keywords: ui-feedback good-first-bug has-patch
Cc:

Description (last modified by SergeyBiryukov)

I wrote a blog post on this and someone suggested I submit here. I found the css adjstument I made below my link to the bug description on my blog seems to fix it:

http://whoischris.com/this-bothers-me-more-than-it-should-or-should-it/

@media screen and (max-width: 960px) {
.col-10, .col-10 .col-3 {
    -moz-box-sizing: border-box;
    -webkit-box-sizing: border-box;
    box-sizing: border-box;
    width: 100%;
    margin: 5px 0;
    padding: 0 15px;
}
}

Attachments (2)

1417.patch (521 bytes) - added by Craig Ralston 4 years ago.
1417.1.patch (635 bytes) - added by Craig Ralston 4 years ago.
created patch from root

Download all attachments as: .zip

Change History (8)

#1 @SergeyBiryukov
4 years ago

  • Description modified (diff)

#2 @Otto42
4 years ago

  • Keywords good-first-bug added

The issue mentioned on the blog post is that the login button on mobile devices touches the banner. Probably needs a bit of padding there.

Patch would need to be made somewhere in the main wp4.css file:
https://meta.svn.wordpress.org/sites/trunk/wordpress.org/public_html/style/wp4.css

Header bump would be required after push for cache busting.

@Craig Ralston
4 years ago

#3 @Craig Ralston
4 years ago

  • Keywords has-patch added

1417.patch adjusts line-height of the h2 to match the height of its' container, which means we can get rid of the padding there and we don't have to rely on the padding-top for the login area, which allows us to properly pad the container without needing media queries.

Before patch:

http://dakota-code.com/images/before.jpg

After patch:

http://dakota-code.com/images/after.jpg

Last edited 4 years ago by Craig Ralston (previous) (diff)

@Craig Ralston
4 years ago

created patch from root

This ticket was mentioned in Slack in #meta by ocean90. View the logs.


4 years ago

#5 @samuelsidler
4 years ago

  • Owner set to samuelsidler
  • Status changed from new to assigned

#6 @Ipstenu
3 years ago

  • Resolution set to worksforme
  • Status changed from assigned to closed

This appears to have been fixed (for plugins at least) in the latest version of the new design.

wordpress.org/plugins-wp/ looks nice on mobile and resizes properly.

I'm closing this. If it's still a problem, we can reopen :)

Worksforme because of new directory work! Yay!

Note: See TracTickets for help on using tickets.