#1504 closed enhancement (fixed)
Improve functionality surrounding comment examples in the developer reference
Reported by: | netweb | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Developer Hub | Keywords: | has-screenshots has-patch |
Cc: |
Description
I just hit upon an "example" on the developer reference that is not correct:
https://developer.wordpress.org/reference/functions/register_post_type/#comment-925
In the example linked the comment mentions that with_front
default is false
, in fact the default is true
At the moment all I can do is downvote the example comment, there is no way to provide context or feedback to the original user the reason for down voting their example.
The original author is also unable to edit or update their example.
Some ideas for improving this functionality:
- Maybe allow replies to examples so feedback can be added (i.e. You could reply and explain your down vote)
- Allow authors to edit and update their examples.
Attachments (7)
Change History (21)
This ticket was mentioned in Slack in #meta-devhub by drew. View the logs.
8 years ago
#4
@
8 years ago
This ticket was discussed in Slack.
https://wordpress.slack.com/archives/meta-devhub/p1470161139000258
Users should be able to edit and add feedback on notes in the front end by creating new endpoints like reference/contributer-note/33434
and reference/contributer-note/33434/edit
.
Edits to a note should be sent into moderation. For now, users should be given the ability to edit their own notes while it's in moderation. At a later time, when we start auto-approving comments based on X-number of approved comments, we should grant these users the ability to edit-after-publish for a set time duration.
#5
@
8 years ago
I've been playing around with adding feedback (replying) to notes in the single post page itself. I was wondering if the notes would get too cluttered or unintuitive if we did it this way instead of adding new endpoints.
This is what I've done so far:
- Note feedback is added to the note itself but is hidden if Javascript is enabled.
- Use a separate editor for adding feedback with only the
strong
,em
, andinline code
buttons (and no preview).
A drawback is that you can't link directly (with a #) to feedback notes that are hidden. The following screenshots will give you an idea.
Feedback for this approach is appreciated :)
This ticket was mentioned in Slack in #meta-devhub by coffee2code. View the logs.
8 years ago
#8
@
8 years ago
- Keywords has-patch added
The 1504.patch Is a first pass at adding feedback to user contributed notes. It ditches the wp_list_comments()
function (again) to have more control over the display of feedback (child) comments. Feedback comments are nested one level deep. The use of HTML in feedback comments is restricted to <strong>
, <em>
, <code>
and <a>
. Newlines are removed. You can also add feedback with this patch if Javascript is disabled.
#9
@
8 years ago
Patch 1504.2.patch is tested in all modern browsers. It looks good in ie9 and up, with minor differences. In ie8 there is an error and the JS doesn't apply (jQuery: “Unexpected call to method or property access”). You can still see and add feedback in ie8.
#10
@
8 years ago
Related: #2082 - Enable revisions on the front end for DevHub/HelpHub/Handbook pages
- Adding revisions to users edited contributor notes on devhub is another potential example of helpful revisions
This ticket was mentioned in Slack in #meta by tellyworth. View the logs.
6 years ago
#13
@
6 years ago
- Resolution set to fixed
- Status changed from new to closed
Closing this as fixed, if there is anything else outstanding please create new ticket or tickets please
Also, the author name for that comment is empty for some reason.