#1627 closed defect (bug) (fixed)
i18n on developer.wordpress.org
Reported by: | ramiy | Owned by: | coffee2code |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Developer Hub | Keywords: | |
Cc: |
Description
Fixing the theme i18n.
See the attached patch.
Attachments (1)
Change History (7)
#2
@
9 years ago
Not duplicate but related.
This ticket is about internationalizing the "developer" site theme (see the attached patch).
#658 is about internationalizing the "developer" site content (parsed documentation from the WordPress source code).
#3
@
9 years ago
- Owner set to coffee2code
- Resolution set to fixed
- Status changed from new to closed
In 2779:
#4
follow-up:
↓ 5
@
9 years ago
@coffee2code,
In my patch I fixed two files (content-reference.php
and content-wp-parser-hook.php
),
in your changeset you fixed only one file (content-reference.php
).
Basically, it's the same change for both files.
I think you should consider updating the second file too.
#5
in reply to:
↑ 4
@
9 years ago
Replying to ramiy:
In my patch I fixed two files (
content-reference.php
andcontent-wp-parser-hook.php
),
in your changeset you fixed only one file (content-reference.php
).
Basically, it's the same change for both files.
I think you should consider updating the second file too.
If I remember correctly, we don't actually use content-wp-parser-hook.php
anymore for simplicity. The get_template_part()
calls toggle for content-{$post_type}
only for non-parsed post types since [1675].
I would guess that's why @coffee2code didn't update it with your changes, as it's likely to be removed in the future.
Duplicate of #658?