WordPress.org
Get WordPress

Making WordPress.org

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#1659 closed defect (bug) (fixed)

Sort by "Time" broken in Sessions Custom Post Type

Reported by: sbrinley's profile sbrinley Owned by: iandunn's profile iandunn
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: good-first-bug has-patch needs-testing
Cc:

Description

This is for the WordCamp version of WordPress. In the “Sessions” Custom Post Type, when I try to sort by time, everything disappears and it says "No sessions found”.

Attachments (1)

1659.patch​ (1011 bytes) - added by juanfra 9 years ago.
There was a code trying to apply a patch to core that was resolved versions ago. By deleting that should work just fine. Also, the session time is a default custom field now, so it'll be always be present.

Download all attachments as: .zip

Change History (5)

#1 @iandunn
9 years ago

  • Keywords needs-patch good-first-bug added
  • Owner set to iandunn
  • Status changed from new to accepted

@juanfra
9 years ago

There was a code trying to apply a patch to core that was resolved versions ago. By deleting that should work just fine. Also, the session time is a default custom field now, so it'll be always be present.

#2 @juanfra
9 years ago

Thanks for the heads up @sbrinley, nice catch!

I've submitted a patch, let's see how it goes.

Last edited 9 years ago by juanfra (previous) (diff)

#3 @juanfra
9 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

#4 @iandunn
9 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 3042:

WordCamp Post Types: Remove unnecessary hack to fix sorting sessions by time.

The problem with meta queries was fixed in ​[wp27689], and after that was deployed, this hack caused sorting by time to break.

Props juanfra
Fixes #1659

Note: See TracTickets for help on using tickets.