Sponsor Info to have billing and contact emails

[Kenshino]

Hello,

So I received a unique case whereby the sponsor has a specific contact address and another billing address for emails.

Unfortunately, we could only put one email, so I'm keeping track of the contact email out of the system.

This is because the billing email is more relevant in the system for invoicing.

I think the system should be used for both archival, contact and billing purposes.

Let me know if it sounds okay and I'll make a patch.

[coreymckrill]

Since other emails/address values wouldn't be used for anything in the system, I probably wouldn't create specific fields for them. As soon as we label a field for a specific purpose, another case with a slight variation will come up.

Perhaps we could just add a general "Notes" field where things like this could go for reference/archival purposes?

[iandunn]

We discussed this in today's bug scrub, and agreed that a general-purpose "notes" field would be a good approach. @Kenshino said that he'd work on a patch.

[hlashbrooke]

Adds 'Sponsor Notes' metabox to wcb_sponsor CPT

[hlashbrooke]

Display of new 'Spnosor Notes' metabox

[hlashbrooke]

I put together 1794.diff above that solves this problem. As you can see in the screenshot above, it adds a 'Sponsor Notes' metabox to the wcb_sponsor post type. I copied the code for this metabox from the notes metabox on Reimbursement Requests, so the UI will be consistent across the different post types, and the code will be easy to maintain as there is nothing 'new' as such.

I had to add some very minor CSS to wc-post-types/css/admin.css, so I'm not sure if that means the CSS version number needs to be bumped or not (or is that done automatically when CSS changes merged?).

As with Reimbursement Requests, the (visible to organizers) string only shows up for network admins.

I think this solves the ticket completely, but happy to rework the patch, or add more to it if needed.

[hlashbrooke]

Adding new metabox view file

[hlashbrooke]

Whoops - forgot to add the new view file to the commit. See 1794.1.diff for the now complete patch.

[iandunn]

The patch needs some minor work based on Slack discussion linked above.

[dd32]

This ticket has been moved to GitHub ​https://github.com/WordPress/wordcamp.org/issues/587