WordPress.org

Making WordPress.org

Opened 3 years ago

Last modified 2 months ago

#1794 assigned enhancement

Sponsor Info to have billing and contact emails

Reported by: Kenshino Owned by: Kenshino
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: good-first-bug has-screenshots needs-patch
Cc:

Description

Hello,

So I received a unique case whereby the sponsor has a specific contact address and another billing address for emails.

Unfortunately, we could only put one email, so I'm keeping track of the contact email out of the system.

This is because the billing email is more relevant in the system for invoicing.

I think the system should be used for both archival, contact and billing purposes.

Let me know if it sounds okay and I'll make a patch.

Attachments (3)

1794.diff (2.9 KB) - added by hlashbrooke 19 months ago.
Adds 'Sponsor Notes' metabox to wcb_sponsor CPT
Screenshot_20180223_113016.png (64.4 KB) - added by hlashbrooke 19 months ago.
Display of new 'Spnosor Notes' metabox
1794.1.diff (4.3 KB) - added by hlashbrooke 19 months ago.
Adding new metabox view file

Download all attachments as: .zip

Change History (13)

#1 @coreymckrill
2 years ago

  • Keywords needs-patch good-first-bug added
  • Type changed from defect to enhancement

Since other emails/address values wouldn't be used for anything in the system, I probably wouldn't create specific fields for them. As soon as we label a field for a specific purpose, another case with a slight variation will come up.

Perhaps we could just add a general "Notes" field where things like this could go for reference/archival purposes?

This ticket was mentioned in Slack in #meta-wordcamp by iandunn. View the logs.


2 years ago

#3 @iandunn
2 years ago

  • Owner set to Kenshino
  • Status changed from new to assigned

We discussed this in today's bug scrub, and agreed that a general-purpose "notes" field would be a good approach. @Kenshino said that he'd work on a patch.

@hlashbrooke
19 months ago

Adds 'Sponsor Notes' metabox to wcb_sponsor CPT

@hlashbrooke
19 months ago

Display of new 'Spnosor Notes' metabox

#4 @hlashbrooke
19 months ago

  • Keywords has-patch added; needs-patch removed

I put together 1794.diff above that solves this problem. As you can see in the screenshot above, it adds a 'Sponsor Notes' metabox to the wcb_sponsor post type. I copied the code for this metabox from the notes metabox on Reimbursement Requests, so the UI will be consistent across the different post types, and the code will be easy to maintain as there is nothing 'new' as such.

I had to add some very minor CSS to wc-post-types/css/admin.css, so I'm not sure if that means the CSS version number needs to be bumped or not (or is that done automatically when CSS changes merged?).

As with Reimbursement Requests, the (visible to organizers) string only shows up for network admins.

I think this solves the ticket completely, but happy to rework the patch, or add more to it if needed.

@hlashbrooke
19 months ago

Adding new metabox view file

#5 @hlashbrooke
19 months ago

Whoops - forgot to add the new view file to the commit. See 1794.1.diff for the now complete patch.

#6 @hlashbrooke
19 months ago

  • Keywords has-screenshots added

This ticket was mentioned in Slack in #meta-wordcamp by iandunn. View the logs.


11 months ago

#8 @iandunn
11 months ago

The patch needs some minor work based on Slack discussion linked above.

This ticket was mentioned in Slack in #meta-wordcamp by iandunn. View the logs.


2 months ago

#10 @iandunn
2 months ago

  • Keywords needs-patch added; dev-feedback has-patch removed
Note: See TracTickets for help on using tickets.