Opened 8 years ago
Closed 7 years ago
#2100 closed defect (bug) (fixed)
Google+ profile links are broken in Tagregator
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | Priority: | low | |
Component: | WordCamp Site & Plugins | Keywords: | good-first-bug has-patch commit |
Cc: |
Description
They link to https://plus.google.com/{username}
, which doesn't exist. They should link to https://plus.google.com/{user_id}
instead.
Example: https://2016.seattle.wordcamp.org/social-media-stream/
Attachments (2)
Change History (11)
#2
@
7 years ago
Alrighty, I'm sure that I've found the way
I've originally tested by changing 'username' => $postmeta['author_name'][0],
to get author_id
instead and that worked fine.
So I've created an extra var 'userId' => $postmeta['author_id'][0],
and changed the index.jsx accordingly with href={ url + author.userId }
.
My problem is that I have no idea how to recompile it into front-end.js so I can't see the changes to be sure they work... ( I know they should be working but just to be sure ).
Shouldn't the recompile happen automatically or something?
By the way, I've never worked with React so this was a good-first-bug for me to try and tackle I guess :D .
Best regards,
Konstantinos
#4
@
7 years ago
There was an issue with my editor so I've updated the diff ( 2100.2.diff ) to meet the coding standards. Sorry for the inconvenience.
Best regards,
Konstantinos
#7
@
7 years ago
Works on my test site 👍🏻 Just need to run npm install
and npm run build
to create the built javascript file front-end.js
. It looks like this also generates some soucemap (*.map
) files, those can be ignored. Maybe the webpack config should be updated to not create those when running build.
I'll take this on if no one else wants it. Should be an easy enough fix I'm guessing. I'll look into it.