Making WordPress.org

Opened 5 years ago

Closed 20 months ago

#2119 closed defect (fixed)

Profiles: Notifications should have an option to match whole words only

Reported by: SergeyBiryukov Owned by:
Milestone: Priority: normal
Component: Profiles Keywords:

Description (last modified by SergeyBiryukov)

One of ru_RU forum administrators has a notification for yui (her WP.org display name and Slack username).

She's getting unrelated notifications for strings like wp-content/plugins/widget-options/assets/css/jqueryui.

There should be an option to match whole words only to avoid irrelevant matches.

Change History (9)

#1 @Otto42
5 years ago

Ideally, I think this should be extended to all usernames should be whole-word only. I don't want to get notifications for "bottom" or something like that either.

#2 @SergeyBiryukov
5 years ago

  • Description modified (diff)

#3 @netweb
5 years ago

Yes please, I currently get notifications for user netweb logic (Without the space) and I'd rather not

#4 @netweb
5 years ago

Another use case is the #polyglots team suggests notification subscriptions to your locale, e.g #pt-br for Portuguese (Brazil), though subscribers to #pt for Portuguese (Portugal) would receive both locales notifications.

#5 @SergeyBiryukov
5 years ago

And subscribers to #fr for French (France) currently get notifications for things like #front-page :)

#6 @denisco
5 years ago

Is there a chance that this will be corrected in the near future? Or will the source code of notifications be opened?

#7 @fierevere
5 years ago

I'm getting 2/3 false notifications for "Yui", not just JqueryUi but random strings and even other usernames like

Hi @tzyyyuin

matching should be done versus exact string, otherwise such notifications are close to useless

This ticket was mentioned in Slack in #polyglots by yui. View the logs.

4 years ago

#9 @dd32
20 months ago

  • Resolution set to fixed
  • Status changed from new to closed

In r15905-dotorg:

Notifications: Limit notification matchers to full word matches only.

This should reduce the number of matchers being issued for short-phrases and irrelevant matches.

Fixes https://meta.trac.wordpress.org/ticket/2119.

GTE Locale and @ username matches were already limited to full-word matches, that brings the other matchers inline with it.

Note: See TracTickets for help on using tickets.