WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 21 months ago

#2131 closed enhancement (fixed)

Submit video page CSS issue

Reported by: casiepa Owned by: obenland
Milestone: Priority: normal
Component: WordPress.tv Keywords: has-patch
Cc:

Description

On page http://wordpress.tv/submit-video/ the very last line where the video filename is to be attached has arrows for scrolling, but there is nothing to scroll.

In the CSS .video-upload p { overflow: auto; } is probably the issue (thanks @dd32)
As @ocean90 indicated : A proper clearfix should be used instead.

Thanks for changing.

Attachments (3)

2131.diff (527 bytes) - added by audrasjb 2 years ago.
fix overflow issue #2131
2131-2.diff (29.9 KB) - added by audrasjb 2 years ago.
no more display block on already block-level HTML element
2131.3.diff (508 bytes) - added by audrasjb 2 years ago.
Good patch to grab in order to fix this issue

Download all attachments as: .zip

Change History (12)

This ticket was mentioned in Slack in #wptv by jerrysarcastic. View the logs.


3 years ago

#2 @audrasjb
2 years ago

  • Keywords has-patch added

Hi,

I try to work on this ticket but I can't understand why my git status on my local branch for this ticket don't retrieve any change between the meta-environment and my branch. As I'm going crazy with that, let's share the small fix for this ticket:

in file anon-upload-template.php located in wp-content/themes/wptv2, replace:

	.video-upload p {
		margin: 16px 0;
		overflow: auto;
	}

with:

	.video-upload p {
		margin: 16px 0;
		display: block;
		overflow: hidden;
	}

Then, Pascal' issue should be fixed. I tested it with several use cases and it works fine.

Sorry, and let's learn deeper how to make a real meta .diff file…

Regard,
Jb

Last edited 2 years ago by audrasjb (previous) (diff)

This ticket was mentioned in Slack in #meta by audrasjb. View the logs.


2 years ago

@audrasjb
2 years ago

fix overflow issue #2131

#4 @SergeyBiryukov
2 years ago

<p> is a block-level element, so adding display: block; here doesn't appear to do anything.

Replacing overflow: auto; with overflow: hidden; should be enough.

#5 @audrasjb
2 years ago

@SergeyBiryukov ok, you're right. Here is a second patch without display:block

@audrasjb
2 years ago

no more display block on already block-level HTML element

@audrasjb
2 years ago

Good patch to grab in order to fix this issue

#6 @audrasjb
2 years ago

@SergeyBiryukov @casiepa my previous patch was uncorrectly built. The last one is the good one :P
Thanks Pascal.

This ticket was mentioned in Slack in #wptv by casiepa. View the logs.


2 years ago

This ticket was mentioned in Slack in #meta-wordcamp by iandunn. View the logs.


2 years ago

#9 @obenland
21 months ago

  • Owner set to obenland
  • Resolution set to fixed
  • Status changed from new to closed

In 6381:

WordPress TV: Avoid scroll display issue.

Props audrasjb, SergeyBiryukov.
Fixes #2131.

Note: See TracTickets for help on using tickets.