WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 2 years ago

#2306 closed defect (fixed)

Block "WordPress" and "Theme" as a theme name

Reported by: grapplerulrich Owned by: Otto42
Milestone: Priority: normal
Component: Theme Review Keywords: has-patch commit
Cc:

Description

The Theme Review Team does not allow themes to have "WordPress" and "theme" in the theme name. The following code in process_upload() of plugins/theme-directory/class-wporg-themes-upload.php

<?php
                // Do not allow themes with WordPress and Theme in the theme name.
                if ( false !== strrpos( $this->theme_slug, 'wordpress' ) || false !== strrpos( $this->theme_slug, 'theme' ) ) {
                        return __( 'You cannot use WordPress or theme in your theme name.', 'wporg-themes' );
                }

Attachments (1)

2306.patch (935 bytes) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (6)

#1 @Otto42
3 years ago

  • Owner set to Otto42
  • Status changed from new to assigned

#2 @ocean90
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 5279:

Theme Directory: Do not allow themes to have "WordPress" and "theme" in the theme name.

Props grapplerulrich.
Fixes #2306.

@SergeyBiryukov
3 years ago

#3 follow-up: @SergeyBiryukov
3 years ago

  • Keywords has-patch commit added
  • Resolution fixed deleted
  • Status changed from closed to reopened

WordPress and theme should not be translatable here: 2306.patch, or at least need quotes around them.

#5 @ocean90
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 5375:

Theme Directory: After [5279] move "WordPress" and "theme" out of the translatable string.

Props SergeyBiryukov.
Fixes #2306.

Note: See TracTickets for help on using tickets.