Making WordPress.org

Opened 3 months ago

Closed 10 days ago

#2418 closed defect (fixed)

Forums: Spam/Unspam/Approve/Unapprove should not be toggles

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: Priority: normal
Component: Support Forums Keywords: has-patch commit

Description (last modified by SergeyBiryukov)

Background: #1965

The Spam/Unspam/Approve/Unapprove actions are currently toggles, which means if two people are looking at the pending queue and both approve a post, it is now un-approved.

The Support Handbook has a workaround to deal with it:

Announce when you are in Spam and/or Pending

Please announce when you are working with spam and/or pending in #forums on Slack, and announce when you are done. The actions are currently hard toggles, meaning that two people clicking “Approve” in the Pending queue simply sends the item right back to the Pending queue. (this will be fixed eventually)

Let's fix this.

Attachments (1)

2418.patch (8.7 KB) - added by SergeyBiryukov 3 weeks ago.

Download all attachments as: .zip

Change History (12)

#1 @SergeyBiryukov
3 months ago

  • Description modified (diff)

This ticket was mentioned in Slack in #bbpress by netweb. View the logs.

2 months ago

#4 @SergeyBiryukov
3 weeks ago

  • Keywords has-patch commit added

2418.patch converts Spam/Unspam, Unapprove/Approve toggle links to explicit actions to avoid conflicts.

3 weeks ago

#5 @SergeyBiryukov
3 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 5290:

Support Forums: Convert Spam/Unspam, Unapprove/Approve toggle links to explicit actions.

By default, bbPress treats them as toggles, which may cause conflicts if the same action is performed twice by different moderators.

Fixes #2418.

#6 @SergeyBiryukov
3 weeks ago

In 5306:

Support Forums: Add handlers for Spam/Unspam, Unapprove/Approve topic and reply action requests.

This is necessary for [5290] to work on bbPress 2.5.x.

See #2418.

This ticket was mentioned in Slack in #forums by macmanx. View the logs.

2 weeks ago

#8 @SergeyBiryukov
2 weeks ago

In 5329:

Support Forums: Convert Close/Open, Stick/Unstick toggle links to explicit actions.

See #2418.

#9 @Otto42
12 days ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Sticking and unsticking topics in plugin forums is now broken, just returns a -1 response.


#10 @Otto42
12 days ago

Related #2747

#11 @SergeyBiryukov
10 days ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 5358:

Support Forums: Rename Stick/Unstick action keys for plugin and theme topics in Stickies_Compat to avoid conflicts with the same actions for regular topics.

See #2747. Fixes #2418.

Note: See TracTickets for help on using tickets.