Forums: Spam/Unspam/Approve/Unapprove should not be toggles

[SergeyBiryukov]

Background: #1965

The Spam/Unspam/Approve/Unapprove actions are currently toggles, which means if two people are looking at the pending queue and both approve a post, it is now un-approved.

The Support Handbook has a ​workaround to deal with it:

Announce when you are in Spam and/or Pending

Please announce when you are working with spam and/or pending in #forums on Slack, and announce when you are done. The actions are currently hard toggles, meaning that two people clicking “Approve” in the Pending queue simply sends the item right back to the Pending queue. (this will be fixed eventually)

Let's fix this.

[netweb]

See ​https://bbpress.trac.wordpress.org/ticket/3032

[SergeyBiryukov]

2418.patch​ converts Spam/Unspam, Unapprove/Approve toggle links to explicit actions to avoid conflicts.

[SergeyBiryukov]

In 5290:

Support Forums: Convert Spam/Unspam, Unapprove/Approve toggle links to explicit actions.

By default, bbPress treats them as toggles, which may cause conflicts if the same action is performed twice by different moderators.

Fixes #2418.

[SergeyBiryukov]

In 5306:

Support Forums: Add handlers for Spam/Unspam, Unapprove/Approve topic and reply action requests.

This is necessary for [5290] to work on bbPress 2.5.x.

See #2418.

[SergeyBiryukov]

In 5329:

Support Forums: Convert Close/Open, Stick/Unstick toggle links to explicit actions.

See #2418.

[Otto42]

Sticking and unsticking topics in plugin forums is now broken, just returns a -1 response.

​https://wordpress.org/support/topic/stick-and-unstick-problem/

[Otto42]

Related #2747

[SergeyBiryukov]

In 5358:

Support Forums: Rename Stick/Unstick action keys for plugin and theme topics in Stickies_Compat to avoid conflicts with the same actions for regular topics.

See #2747. Fixes #2418.