Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#2495 closed defect (bug) (fixed)

Support Theme: Replace div:nth-child selectors with classes

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: Priority: normal
Component: Support Forums Keywords: has-patch commit


The theme uses a couple of cryptic div:nth-child selectors to hide "Browse Plugins" and "Search Plugins" blocks in the sidebar for plugin support topics (same for themes).

This leads to inadvertent hiding of "Feeds" and "Tags" blocks in Pending/Spam views.

Explicitly defined CSS classes should be used instead.

Attachments (3)

meta-2495.patch (174.5 KB) - added by SergeyBiryukov 7 years ago.
meta-2495.2.patch (178.0 KB) - added by SergeyBiryukov 7 years ago.
meta-2495.3.patch (176.8 KB) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (9)

#1 @SergeyBiryukov
7 years ago

It looks like these sections are never actually displayed anywhere. They are added on plugin and theme support/review topic lists, but end up being hidden in the theme.

meta-2495.2.patch removes them to prevent further confusion. Any objections?

#2 @SergeyBiryukov
7 years ago

meta-2495.2.patch was too overzealous, it removed the plugin/theme info section too.

meta-2495.3.patch is the way to go.

#3 @SergeyBiryukov
7 years ago

In 4948:

Support Forums: Remove plugin- and theme-specific sidebar sections that are never displayed in the new theme.

See #2495.

#4 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 4949:

Support Theme: Remove plugin- and theme-specific sidebar section styles that are unused since [4948].

Fixes #2495.

#5 @SergeyBiryukov
7 years ago

In 5755:

Support Forums: Remove "About this Plugin/Theme" heading that is never displayed in the theme.

See #2495.

#6 @SergeyBiryukov
7 years ago

In 5756:

Support Theme: Remove styles for hiding the "About this Plugin/Theme" heading removed in [5755].

See #2495.

Note: See TracTickets for help on using tickets.