WordPress.org

Making WordPress.org

Opened 2 years ago

Closed 2 years ago

#2498 closed defect (fixed)

Support Forums: "Resolved" icon markup should not be added in reply edit context

Reported by: SergeyBiryukov Owned by: ocean90
Milestone: Priority: normal
Component: Support Forums Keywords: has-patch commit
Cc:

Description

Same as #2399, but for Edit Reply page.

See the screenshot.

Attachments (6)

meta-2498.PNG (25.0 KB) - added by SergeyBiryukov 2 years ago.
meta-2498.patch (793 bytes) - added by SergeyBiryukov 2 years ago.
meta-2498.2.PNG (5.3 KB) - added by SergeyBiryukov 2 years ago.
meta-2498.2.patch (834 bytes) - added by SergeyBiryukov 2 years ago.
meta-2498.3.patch (1.1 KB) - added by SergeyBiryukov 2 years ago.
meta-2498.4.patch (877 bytes) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (11)

#1 follow-up: @SergeyBiryukov
2 years ago

meta-2498.2.patch also disables the icon on single replies. It's displayed in the wrong place: meta-2498.2.PNG, and seems unnecessary there anyway.

#3 @ocean90
2 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 4998:

Support Forums, Topic Resolution: Don't modify topic title in feeds and on a single reply or reply edit page.

Props SergeyBiryukov.
Fixes #2498, #2533.

#4 in reply to: ↑ 1 @SergeyBiryukov
2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to SergeyBiryukov:

meta-2498.2.patch also disables the icon on single replies. It's displayed in the wrong place: meta-2498.2.PNG

Fixed the icon position in breadcrumbs in [5020], so this part can be reverted now. See meta-2498.4.patch.

#5 @coffee2code
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 5039:

Support Forums, Topic Resolution: Revert temporary disabling of resolved icon for single reply views from [4998] now that its display is handled in [5020].

Props SergeyBiryukov.
Fixes #2498.

Note: See TracTickets for help on using tickets.