![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 9 years ago
Closed 9 years ago
#2583 closed defect (bug) (fixed)
Tagregator filters every request with function that can throw "undefined index" notices
| Reported by: | coreymckrill | Owned by: | coreymckrill |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | WordCamp Site & Plugins | Keywords: | |
| Cc: |
Description
Tagregator currently has four different "source" classes that it uses to aggregate hashtag data. Each of these classes adds a filter to the request hook so that the items in their Post Lists can be sorted by a particular post meta value. The filter checks for an orderby query var, and then compares the source's CPT to the post_type query var.
The problem is that some requests don't have a post_type query var, and if WP_DEBUG is turned on, this will throw an Undefined index: post_type notice, which can be especially problematic for Ajax and REST API requests. It also seems a bit overkill to filter every request when the sorting is only used on very specific admin screens.
Attachments (1)
Change History (3)
Note:
See TracTickets
for help on using tickets.
Looks good to me :)