Plugin Directory: Same id is used twice

[nico23]

You use the same

#screenshots

id twice.

[SergeyBiryukov]

Hi @nico23, could you clarify where the duplicate ID is?

I can only see one instance in the source code, and it's the same instance that is displayed on a single plugin page.

[nico23]

Replying to SergeyBiryukov:

Hi @nico23, could you clarify where the duplicate ID is?

I can only see one instance in the source code, and it's the same instance that is displayed on a single plugin page.

Looks like you have not bothered to look at the source in the browser. I attached a screenshot from Firefox 52 devtools. If its not in the html/php then its created with JS I guess.

data-react-root ?

So you use React on wp.org already but can't be bothered to code tabs. Thats funny. I have no clue about react but what what wp.org plugin dir is doing at this time its not needed at all. Probably even harder to do things and you end up with things like this. I found out about this because in my userscript #2679 I need to take specific care to handle this case.

[SergeyBiryukov]

Thanks, reproduced now with Chrome dev tools as well.

[ocean90]

In 5454:

Plugin Directory: Replace the #screenshot container when inserting the screenshot slider.

Fixes #2680.