Invalid values in Devhub_Handbooks::add_query_vars() for query_vars

[grapplerulrich]

The values for query_vars needs to be a STRING and INTEGER value.

This is currently not the case. https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/handbooks.php#L64

array(5) {
  ["is_handbook"] => bool(false)
  ["current_handbook"] =>bool(false)
  ["current_handbook_home_url"] =>bool(false)
  ["current_handbook_name"] => string(0) ""
  ["empty_post_type_search"] => bool(false)
}

Related ​#core38401

[grapplerulrich]

The invalid values have been replaced with valid variables or switched to properties like done previously [4294]

[johnbillion]

2882.patch​ does not look correct to me. The query_vars filter expects the query variable names as values of the array. The keys are not relevant.

[SergeyBiryukov]

2882.patch​ seems correct to me.

[4294] fixed the issue for is_handbook_root, but a similar issue with empty_post_type_search was missed.

[johnbillion]

2882.patch​ might fix the issue, but it's incorrect. The query vars passed through the query_vars filter is an array with query vars as the array element values, not query vars as the array element keys. It's filtering the WP::$public_query_vars property.

[SergeyBiryukov]

Replying to johnbillion:

The query vars passed through the query_vars filter is an array with query vars as the array element values, not query vars as the array element keys.

Right, but query vars as array element keys is the current code, not what the patch suggests. The patch removes the invalid filter usage for empty_post_type_search, same as [4294] did for is_handbook_root. Why is that incorrect?

[johnbillion]

Replying to SergeyBiryukov:

Right, but query vars as array element keys is the current code, not what the patch suggests. The patch removes the invalid filter usage for empty_post_type_search, same as [4294] did for is_handbook_root. Why is that incorrect?

Yes you're correct, but the Devhub_Handbooks::add_query_vars() method still includes incorrect usage.

[grapplerulrich]

@johnbillion @SergeyBiryukov I have relooked at the documentation and fixed query_vars so that the names are as values and not keys.

I have tested the code locally..

The tests that I did were to check

• that rest-api-handbook-reference is being added to ​https://developer.wordpress.org/rest-api/reference/posts/
• In the breadcrumbs of search.php that the handbook URL and name are being defined.

[ocean90]

#3607 was marked as a duplicate.

[obenland]

@SergeyBiryukov Is this ready to go?

[obenland]

In 7319:

Developer: Use query_vars correctly.

Props grapplerulrich, johnbillion, SergeyBiryukov.
Fixes #2882.