WordPress.org

Making WordPress.org

Opened 2 years ago

Closed 23 months ago

Last modified 23 months ago

#2928 closed defect (fixed)

New responsive styles in wp4.css break Codex layout

Reported by: SergeyBiryukov Owned by: coffee2code
Milestone: Priority: normal
Component: Codex Keywords: has-patch
Cc:

Description

Just noticed that when you're logged in on Codex, the sidebar is now on the left, overlapping with the footer on shorter articles (see the screenshot).

Looking at https://s.w.org/style/wp4.css?58, these styles appear to be the culprit:

.wporg-responsive .col-7,
body.wporg-responsive .col-8,
body.wporg-responsive .col-10 {
	margin-left: 174px;
}
body.wporg-responsive .col-2 {
	position: absolute;
}

Once I disable them in Chrome inspector, the layout is correct again.

Attachments (2)

2928.png (126.1 KB) - added by SergeyBiryukov 2 years ago.
2928.diff (657 bytes) - added by sagarprajapati 2 years ago.

Download all attachments as: .zip

Change History (14)

@SergeyBiryukov
2 years ago

@sagarprajapati
2 years ago

#1 @sagarprajapati
2 years ago

  • Keywords has-patch added

Hi @SergeyBiryukov

I have attached patch for the above issue. Please check it.

Thanks

#2 @coffee2code
2 years ago

  • Owner set to coffee2code
  • Status changed from new to accepted

#3 follow-up: @SergeyBiryukov
2 years ago

Hmm, looks like these styles aren't really new, they were added 2 years ago in [1469].

But for some reason they didn't affect Codex before, unless I somehow managed to miss it for two years :)

Last edited 2 years ago by SergeyBiryukov (previous) (diff)

This ticket was mentioned in Slack in #meta by sagarprajapati. View the logs.


2 years ago

#6 in reply to: ↑ 3 @SergeyBiryukov
2 years ago

Replying to SergeyBiryukov:

Hmm, looks like these styles aren't really new, they were added 2 years ago in [1469].

But for some reason they didn't affect Codex before, unless I somehow managed to miss it for two years :)

The <body> tag has these classes now: wporg-responsive wporg-codex, which were not there a few months ago, that explains it.

#7 @SergeyBiryukov
23 months ago

#2995 was marked as a duplicate.

#10 @coffee2code
23 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 5786:

Codex: Add responsive styling to override default responsive styling and keep sidebar on the right.

Fixes #2928.

#11 @coffee2code
23 months ago

@sagarprajapati: Thanks for the patch! However, wp4.css is used throughout the wordpress.org ecosystem and affects many sites. The changes you proposed would fix things for the Codex, but would break the layout of most other sites. I ended up making and testing more directed changes in codex-wp4.css.

#12 @coffee2code
23 months ago

The Codex caches the w.org page header so the change likely won't take effect immediately. It's likely it may require a cache reset by systems, so if things don't appear fixed in the next day or two, I'll put in the request.

Note: See TracTickets for help on using tickets.