#2928 closed defect (bug) (fixed)
New responsive styles in wp4.css break Codex layout
Reported by: | SergeyBiryukov | Owned by: | coffee2code |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Codex | Keywords: | has-patch |
Cc: |
Description
Just noticed that when you're logged in on Codex, the sidebar is now on the left, overlapping with the footer on shorter articles (see the screenshot).
Looking at https://s.w.org/style/wp4.css?58, these styles appear to be the culprit:
.wporg-responsive .col-7, body.wporg-responsive .col-8, body.wporg-responsive .col-10 { margin-left: 174px; } body.wporg-responsive .col-2 { position: absolute; }
Once I disable them in Chrome inspector, the layout is correct again.
Attachments (2)
Change History (14)
#3
follow-up:
↓ 6
@
7 years ago
Hmm, looks like these styles aren't really new, they were added 2 years ago in [1469].
But for some reason they didn't affect Codex before, unless I somehow managed to miss it for two years :)
#4
@
7 years ago
For reference, the URL on the screenshot is https://codex.wordpress.org/ЧАВО/Проблемы_с_кодировкой.
This ticket was mentioned in Slack in #meta by sagarprajapati. View the logs.
7 years ago
#6
in reply to:
↑ 3
@
7 years ago
Replying to SergeyBiryukov:
Hmm, looks like these styles aren't really new, they were added 2 years ago in [1469].
But for some reason they didn't affect Codex before, unless I somehow managed to miss it for two years :)
The <body>
tag has these classes now: wporg-responsive wporg-codex
, which were not there a few months ago, that explains it.
#8
@
7 years ago
To reproduce, just go to https://codex.wordpress.org/User_talk:Gk.loveweb.
#9
@
7 years ago
https://codex.wordpress.org/Changelog/4.8 has the same issue.
#11
@
7 years ago
@sagarprajapati: Thanks for the patch! However, wp4.css
is used throughout the wordpress.org ecosystem and affects many sites. The changes you proposed would fix things for the Codex, but would break the layout of most other sites. I ended up making and testing more directed changes in codex-wp4.css
.
Hi @SergeyBiryukov
I have attached patch for the above issue. Please check it.
Thanks