WordPress.org

Making WordPress.org

Opened 6 years ago

Closed 5 years ago

#307 closed enhancement (wontfix)

Let the Sponsors widget link to the sponsor's website.

Reported by: georgestephanis Owned by:
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: needs-testing
Cc:

Description

To match the shortcode changes in r235

Attachments (3)

meta-307.diff (2.2 KB) - added by georgestephanis 6 years ago.
widgets1.php-meta-307.diff (957 bytes) - added by bansod_deven 5 years ago.
Added A patch. Checks if the Website Field is updated for the sponsor. If yes, links the Image to it. Else, links the image to the Permalink. Hope it works
widgets2.php-meta-307.diff (2.5 KB) - added by bansod_deven 5 years ago.
Tried to incorporate what georgestephanis suggested.

Download all attachments as: .zip

Change History (7)

#1 @bansod_deven
5 years ago

  • Cc devenbansod.bits@… added
  • Keywords needs-testing added

Added A patch.
Checks if the Website Field is updated for the sponsor.
If yes, links the Image to it.
Else, links the image to the Permalink.

Hope it works.

@bansod_deven
5 years ago

Added A patch. Checks if the Website Field is updated for the sponsor. If yes, links the Image to it. Else, links the image to the Permalink. Hope it works

#2 @georgestephanis
5 years ago

I'd personally rather see it as a widget option which you'd prefer to use -- if they choose website, but hadn't entered one, then do as you'd done -- and fall back to the permalink.

@bansod_deven
5 years ago

Tried to incorporate what georgestephanis suggested.

#3 @bansod_deven
5 years ago

Added a New Patch file. Tried to incorporate what georgestephanis had suggested.

Checks if the Box in Widget Backend for linking to Sponsor's Website is Checked.

If not checked, links to permalinks.

If checked, checks if Website field is updated and links to it. If not updated, links to permalink.

#4 @andreamiddleton
5 years ago

  • Keywords has-patch removed
  • Resolution set to wontfix
  • Status changed from new to closed

Linking directly to the sponsor website from a logo on the sidebar has the potential to make the IRS think we're selling advertising rather than thanking sponsors. Let's keep people linking to the sponsor post (which can then link to the sponsor's site) rather than linking directly to the sponsor's site from the sidebar.

Note: See TracTickets for help on using tickets.