WordPress.org
Get WordPress

Making WordPress.org

Opened 7 years ago

Closed 7 years ago

#3349 closed defect (bug) (fixed)

Add text domain to make strings translation ready

Reported by: chetan200891's profile chetan200891 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: Priority: normal
Component: Developer Hub Keywords: has-patch
Cc:

Description

There are two strings used without text domain. So it must need text domain to make it translation ready.

Attachments (1)

3349.patch​ (627 bytes) - added by chetan200891 7 years ago.
Created patch.

Download all attachments as: .zip

Change History (4)

@chetan200891
7 years ago

Created patch.

#1 @chetan200891
7 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
7 years ago

Thanks for the patch! AFAIK, the content of ​https://developer.wordpress.org/cli/commands/ is pulled from GitHub, and there are no plans to make it translatable at this time. That said, I don't see any harm in making these strings translatable for consistency with the rest of the theme and potential future use.

#3 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 6305:

developer.wordpress.org: Add missing text domain for table headings in archive-command.php.

Props chetan200891.
Fixes #3349.

Note: See TracTickets for help on using tickets.