Opened 11 years ago
Closed 11 years ago
#338 closed enhancement (invalid)
Expand ICS calendar support for WordCamps
Reported by: | iandunn | Owned by: | |
---|---|---|---|
Milestone: | Priority: | low | |
Component: | WordCamp Site & Plugins | Keywords: | needs-patch good-first-bug |
Cc: |
Description
The current ICS calendar shows WordCamps for the next 15 days, but some people would find it useful to see all past/present/future camps in their calendar.
Adding a URL parameter to the endpoint (e.g., calendar.ics/full
) could be used to distinguish between the 15-day and full calendars without breaking backwards compatibility.
If there are performance issues with showing all camps, then it'd probably be acceptable to limit the past WordCamps to only those within the past 60 days.
The source code is available at https://meta.trac.wordpress.org/browser/sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-api/classes/ics.php
Change History (6)
#2
@
11 years ago
Just that it would change how it behaves now. So, you're right, it wouldn't actually be breaking it, but in my experience remote calendars can be pretty slow, so going from 15 events to ~400 could be significant.
Also, I don't know what the original use case for it was, so it's possible that changing the number of events might disrupt that. @kovshenin, can you give us the back story on the calendar, and your thoughts on changing it to include all events?
#3
@
11 years ago
It's fine if it's only all future WordCamps, plus going back say 60 days.
Honestly, if you're one of the few that wants to have WordCamp dates in your calendar, actually having a useful calendar outweighs speed.
#4
@
11 years ago
Just wanted to point out that the current calendar code actually does show all future events, up to a limit of 50 events. The -15 days mark is days in the past, that query is a greater-than:
'meta_query' => array( array( 'key' => 'Start Date (YYYY-mm-dd)', 'value' => strtotime( '-15 days' ), 'compare' => '>' ) )
The current ICS being output shows everything from WordCamp Prague next Saturday to WordCamp San Francisco in October.
#5
@
11 years ago
@kovshenin, can you give us the back story on the calendar
I was just fooling around, tried to get WordCamps in my own calendar with reminders, that's all, I didn't even know this was used publicly, I never really finished the plugin. No objections to any of the proposed changes, but as Otto pointed out, the -15 days limit is the past. There's a 50 events limit on posts_per_page
too.
What are the backward compatibility issues to just making the main calendar URL show all WordCamps? A 15-day calendar is pretty useless.