Opened 7 years ago
Closed 6 years ago
#3492 closed defect (bug) (fixed)
Email subscription in right side error placing and alignment issue.
Reported by: | Girishpanchal | Owned by: | obenland |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Make (Get Involved) / P2 | Keywords: | has-screenshots has-patch 2nd-opinion |
Cc: |
Description
When I opened https://make.wordpress.org/core/ URL and added invalid email then the error message place below the title of "Email Update". For the better user-friendly, it should below the email input box and the error message should left align.
I have attached the screenshot for the better understanding.
Attachments (2)
Change History (6)
This ticket was mentioned in Slack in #meta by girishpanchal. View the logs.
6 years ago
#3
@
6 years ago
- Keywords has-patch 2nd-opinion added; ui-feedback ux-feedback removed
- Type changed from enhancement to defect
Hello,
This is related to Jetpack subscription module.
In 3492.1.diff
, I removed left and right margins.
I think we can’t move the error notice easily since this is Jetpack territory.
However, I found the related file here: https://github.com/Automattic/jetpack/blob/c041272fde4dc56e7b202ed0eb3253058d10a5ad/modules/subscriptions.php
Maybe I can do a patch and a pull request, but I’m not sure this will be adressed by Automattic since Jetpack is used by a huge lot of websites…
I’d like to get a feedback from Jetpack crew before jumping on it :)
Cheers,
Jb
Screenshot