Making WordPress.org

Opened 6 years ago

Closed 5 years ago

#3942 closed defect (bug) (fixed)

Themes homepage shouldn't rely on JS, and shouldn't call the 'featured' state

Reported by: jonoaldersonwp's profile jonoaldersonwp Owned by:
Milestone: Priority: low
Component: Theme Directory Keywords: seo needs-patch needs-testing
Cc:

Description

When loading https://wordpress.org/themes/, JavaScript is used to immediately change the page state to match that of https://wordpress.org/themes/browse/featured/. This causes SEO, accessibility and analytics headaches.

I'm assuming that the intent is that the 'Featured' view should act as the 'Themes homepage'. If this is the case, then:

  • /themes/browse/featured/ should not exist as a distinct page (and requests to this URL should 301 redirect to /themes/)
  • Meta content (titles, descriptions, open graph tags, etc) for /themes/ should be updated to reflect that this page is both the themes index, _and_ a representation of featured themes.
  • We should remove the JavaScript 'reload' behaviour entirely.

Additionally, the page always loads with a large placeholder containing the text, "No themes found. Try a different search.". This is removed via JS if results are found.

This text should be removed entirely (as the default), and only returned for queries which genuinely return no results.

Change History (8)

This ticket was mentioned in Slack in #meta by jonoaldersonwp. View the logs.


6 years ago

#2 @jonoaldersonwp
6 years ago

  • Keywords seo added

This ticket was mentioned in Slack in #meta by jonoaldersonwp. View the logs.


5 years ago

This ticket was mentioned in Slack in #meta by jonoaldersonwp. View the logs.


5 years ago

This ticket was mentioned in Slack in #themereview by dingo_d. View the logs.


5 years ago

#6 @dingo_d
5 years ago

  • Keywords needs-patch needs-testing added

#7 @dd32
5 years ago

Just noting for future reference that this ticket has overlap with #4681

#8 @jonoaldersonwp
5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

No longer applies, given the removal of the 'featured' themes page.

Note: See TracTickets for help on using tickets.