WordPress.org

Making WordPress.org

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#4029 closed defect (maybelater)

Missing Coding Standards - Core Function Files

Reported by: faisal03 Owned by:
Milestone: Priority: normal
Component: Theme Directory Keywords: has-patch
Cc:

Description

I have gone through some funcitons files and found few things should be fixed as per the coding standard.

Attachments (2)

4029.diff (2.7 KB) - added by faisal03 2 years ago.
4029.2.diff (6.5 KB) - added by faisal03 2 years ago.

Download all attachments as: .zip

Change History (4)

@faisal03
2 years ago

#1 @Otto42
2 years ago

  • Resolution set to maybelater
  • Status changed from new to closed

This patch points to some random file without referent. If it's a core file, then you should be submitting it against core, and even then, it should be more specific as to which "functions.php" file you're changing.

Also, we don't generally do "re-formatting" patches for meta unless they are for whole-site modifications. The coding standards are a guideline, not a straightjacket.

@faisal03
2 years ago

#2 @faisal03
2 years ago

The 4029.diff is for the following file:

/meta/trunk/wordpress.org/public_html/wp-content/themes/pub/gutenberg/functions.php

By the way, I got your point @Otto42. Thanks for the explanation.

Last edited 2 years ago by faisal03 (previous) (diff)
Note: See TracTickets for help on using tickets.