WordPress.org

Making WordPress.org

Opened 7 months ago

Closed 6 months ago

Last modified 6 months ago

#4032 closed defect (fixed)

bug in parser

Reported by: tazotodua Owned by: dd32
Milestone: Priority: normal
Component: Plugin Directory Keywords:
Cc:

Description

there is a bug in parser.

the example readme.txt (of plugin https://wordpress.org/plugins/wc-remove-tabs-and-fields/ )
contains such part:

`

  • Billing state
  • Billing phone
  • Billing email
  • Shipping first name
  • Shipping last name

`

however, in plugin directory, it is rendered incorrectly:

https://i.imgur.com/USpptfn.png

you see extra incorrect spaces between lines.

Change History (4)

#1 @dd32
6 months ago

  • Resolution set to invalid
  • Status changed from new to closed

This is intentional in the Markdown "Specs" as per https://daringfireball.net/projects/markdown/syntax#list although I can see how it seems incorrect at first glance. (Specifically, see the section If list items are separated by blank lines, Markdown will wrap the items in <p> tags in the HTML output.)

I would suggest removing the blank lines from the Markdown file (readme.txt).

We use MarkdownExtra by MichelF which has an interactive demo available which might be of use.

I'm closing this as invalid as I don't want to see any more changes placed upon our markdown treatment, and it being seemingly correct per the libraries followed spec.

#2 @dd32
6 months ago

  • Owner set to dd32
  • Resolution changed from invalid to fixed

In 8037:

Plugin Directory: Remove the margins on li > p in readme contents to avoid lists looking incorrect when list paragraphs are used.

Fixes #4032.

#3 @dd32
6 months ago

With another look at this, I realised that we can work around this with some styling, I think this ultimately results in it looking better than it did before on the whole.

An example of where it looked better previous is https://wordpress.org/plugins/wp-jquery-lightbox/#installation which had consistent spaces between the list items, but now have uneven spacing.

#4 @dd32
6 months ago

In 8038:

Plugin Directory: Cache bump after r8037.

See #4032.

Note: See TracTickets for help on using tickets.