WordPress.org

Making WordPress.org

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#4098 closed defect (fixed)

Burger icon not working in mobile view on ticket

Reported by: pratikgandhi Owned by: ocean90
Milestone: Priority: normal
Component: Trac Keywords: has-screenshots dev-feedback has-patch
Cc:

Description

Hello

Burger icon not working when I was checking the ticket detail page in mobile.
Here is the URL of the page: https://core.trac.wordpress.org/ticket/45459

Thanks

Attachments (2)

Change History (9)

#1 @mukesh27
6 months ago

  • Keywords dev-feedback has-patch added

Hi @pratikgandhi, Welcome to Meta WordPress Trac! Thanks for the report.

Above same issue happen in Meta and Core trac. Issue happen because of before system used toggled class when burger menu click/open but now when we click on burger menu it will use active class instead of toggled and that's the issue.

#wporg-header ul#wporg-header-menu.toggled {
	left: 0;
}

Needs to replace with

#wporg-header ul#wporg-header-menu.active {
	left: 0;
}

@mukesh27
6 months ago

Patch.

#2 @ocean90
6 months ago

In 8147:

Trac/wp4: Add navigation.js which can be shared across w.org.

See #4098.

#3 @ocean90
6 months ago

In 8148:

Trac: Update header templates to match global w.org header.

See #4098.

#4 @ocean90
6 months ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 8149:

Trac: Load navigation.js for mobile navigation menu.

Fixes #4098.

#5 @mukesh27
6 months ago

@ocean90, Still burger menu not working in mobile.

#6 @ocean90
6 months ago

In 8154:

wp4: Query menu list and toggle button by IDs.

Makes the script more robust by not relying on a specific order of elements.

See #4098.

#7 @ocean90
6 months ago

In 8155:

Trac: Bump cache buster for navigation.js.

See #4098.

Note: See TracTickets for help on using tickets.