Making WordPress.org

Opened 2 years ago

Last modified 2 months ago

#4126 accepted defect

"Special contributions" template leaks PII

Reported by: jonoaldersonwp Owned by: tellyworth
Milestone: Priority: high
Component: Codex Keywords: seo analytics privacy


E.g., https://codex.wordpress.org/Special:Contributions/Jany2786@gmail.com

This template should have a meta robots value of 'noindex, follow'.

Change History (11)

#2 @Otto42
2 years ago

For reference, that isn't the email address, it's the username. Those are old spam accounts that used the same values for email and username.

We no longer allow accounts to have email addresses as their username. Been like that for a few years. Usernames must be lowercase alphanum only.

This ticket was mentioned in Slack in #meta by tellyworth. View the logs.

2 years ago

#4 @tellyworth
2 years ago

Can (should) we handle URLs with user=\w+@ in a special way? Force a 404 or 410, redact the address from the page, something like that? Just in case there are any ancient non-spam addresses in there.

#5 @jonoaldersonwp
2 years ago

Hmm, we should probably avoid trying to do anything clever with the URLs on request, but, we can definitely control indexing of these (types of) URLs, and, separately, I've plans to keep them out of Google Analytics etc by doing some housekeeping in Google Tag Manager before tracking scripts fire.

#6 @jonoaldersonwp
23 months ago

For clarity, this still needs noindex'ing.

#7 @tellyworth
18 months ago

  • Owner set to tellyworth
  • Status changed from new to accepted

What's the solution here? Noindex all Special: pages? Just Contributions and Log? Is it specific to those with @ in the URL?

#8 @jonoaldersonwp
18 months ago

Let's noindex anything starting with https://codex.wordpress.org/Special:Contributions/ - I don't see any useful/valuable (landing) pages in that set.

#9 @dd32
3 months ago

Having just cleaned out a lot of spam from the codex, taking into account #4127 and #4373 I think we could noindex

  • ^/User:*
  • ^/User_talk:*
  • ^/Special:*
  • ^/index.php*

User pages do have useful content on some of them, but it's in the minority.

Last edited 3 months ago by dd32 (previous) (diff)

#10 @jonoaldersonwp
2 months ago

Nice, that'd be great!

#11 @dd32
2 months ago

Fixed via r10702-codex pending deploy.

Note: See TracTickets for help on using tickets.