WordPress.org

Making WordPress.org

Opened 4 weeks ago

Closed 6 days ago

Last modified 5 days ago

#4618 closed defect (fixed)

Add responsive embed support to Rosetta websites

Reported by: audrasjb Owned by: SergeyBiryukov
Milestone: Priority: normal
Component: International Sites (Rosetta) Keywords: has-screenshots has-patch
Cc:

Description

Hi,

Embed blocks/iframes are not responsive.
The issue occurs on Rosetta Locales Websites.

See attached screenshots below.

Attachments (4)

meta-before-embed-responsive.png (121.4 KB) - added by audrasjb 4 weeks ago.
Issue with embed blocks on responsive view (before patch)
meta-after-embed-responsive.png (138.7 KB) - added by audrasjb 4 weeks ago.
Patched with 4619.diff
4618.diff (583 bytes) - added by audrasjb 4 weeks ago.
4618.2.diff (1.2 KB) - added by audrasjb 4 weeks ago.
Adds RTL support on the initial patch

Download all attachments as: .zip

Change History (11)

@audrasjb
4 weeks ago

Issue with embed blocks on responsive view (before patch)

@audrasjb
4 weeks ago

Patched with 4619.diff

@audrasjb
4 weeks ago

#1 follow-up: @audrasjb
4 weeks ago

  • Keywords has-patch added

@audrasjb
4 weeks ago

Adds RTL support on the initial patch

This ticket was mentioned in Slack in #meta by audrasjb. View the logs.


6 days ago

#3 @SergeyBiryukov
6 days ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#4 in reply to: ↑ 1 ; follow-up: @SergeyBiryukov
6 days ago

Replying to audrasjb:

4618.diff works fine on my side.

Thanks for the patch! For reference, global.wordpress.org/.../rosetta is the older Rosetta theme, no longer used.

The currently used theme is wordpress.org/.../wporg-main.

#5 @SergeyBiryukov
6 days ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 9103:

WordPress.org Main Theme: Bring _media.scss component from wporg-plugins theme to make embeds and iframes responsive.

Props audrasjb.
Fixes #4618.

#6 @SergeyBiryukov
6 days ago

In 9104:

WordPress.org Main Theme: Bump CSS version for cache bust after [9103].

See #4618.

#7 in reply to: ↑ 4 @audrasjb
5 days ago

Replying to SergeyBiryukov:

Thanks for the patch! For reference, global.wordpress.org/.../rosetta is the older Rosetta theme, no longer used.

The currently used theme is wordpress.org/.../wporg-main.

Oh! Thank you @SergeyBiryukov ! Noted.

Note: See TracTickets for help on using tickets.