WordPress.org
Get WordPress

Making WordPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#4618 closed defect (bug) (fixed)

Add responsive embed support to Rosetta websites

Reported by: audrasjb's profile audrasjb Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: Priority: normal
Component: International Sites (Rosetta) Keywords: has-screenshots has-patch
Cc:

Description

Hi,

Embed blocks/iframes are not responsive.
The issue occurs on Rosetta Locales Websites.

See attached screenshots below.

Attachments (4)

meta-before-embed-responsive.png​ (121.4 KB) - added by audrasjb 5 years ago.
Issue with embed blocks on responsive view (before patch)
meta-after-embed-responsive.png​ (138.7 KB) - added by audrasjb 5 years ago.
Patched with 4619.diff
4618.diff​ (583 bytes) - added by audrasjb 5 years ago.
4618.2.diff​ (1.2 KB) - added by audrasjb 5 years ago.
Adds RTL support on the initial patch

Download all attachments as: .zip

Change History (12)

@audrasjb
5 years ago

Issue with embed blocks on responsive view (before patch)

@audrasjb
5 years ago

Patched with 4619.diff

@audrasjb
5 years ago

#1 follow-up: @audrasjb
5 years ago

  • Keywords has-patch added

4618.diff works fine on my side.

Example page: ​https://fr.wordpress.org/2019/02/21/wordpress-5-1-resume-des-changements-apportes-par-cette-nouvelle-version/

@audrasjb
5 years ago

Adds RTL support on the initial patch

This ticket was mentioned in ​Slack in #meta by audrasjb. ​View the logs.
5 years ago

#3 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#4 in reply to: ↑ 1 ; follow-up: @SergeyBiryukov
5 years ago

Replying to audrasjb:

4618.diff works fine on my side.

Thanks for the patch! For reference, global.wordpress.org/.../rosetta is the older Rosetta theme, no longer used.

The currently used theme is wordpress.org/.../wporg-main.

#5 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 9103:

WordPress.org Main Theme: Bring _media.scss component from wporg-plugins theme to make embeds and iframes responsive.

Props audrasjb.
Fixes #4618.

#6 @SergeyBiryukov
5 years ago

In 9104:

WordPress.org Main Theme: Bump CSS version for cache bust after [9103].

See #4618.

#7 in reply to: ↑ 4 @audrasjb
5 years ago

Replying to SergeyBiryukov:

Thanks for the patch! For reference, global.wordpress.org/.../rosetta is the older Rosetta theme, no longer used.

The currently used theme is wordpress.org/.../wporg-main.

Oh! Thank you @SergeyBiryukov ! Noted.

#8 @dd32
4 years ago

#4204 was marked as a duplicate.

Note: See TracTickets for help on using tickets.