Making WordPress.org

Opened 5 years ago

Closed 5 years ago

#4692 closed defect (bug) (fixed)

HelpHub TOC nested lists styling

Reported by: milana_cap's profile milana_cap Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: Priority: normal
Component: HelpHub (wordpress.org/documentation) Keywords: has-patch
Cc:

Description

Issue Description

TOC doesn't reflect parent-child relationship with indentation of child list. Also, alignment is off.

Context

This is possibly caused by overriding old theme (we already had issue with title font size being too large).

Expected Result:

Style should match TOC found here: https://developer.wordpress.org/themes/functionality/administration-menus/.

Screenshot:
https://box.everhelper.me/attachment/1743476/c070942ipyqeto96dffq/654956-zZ92Zm2eHSaSZSML/screen.jpeg

Actual Result:

This is how it looks now: https://wordpress.org/support/article/first-steps-with-wordpress-b/

Screenshot:
https://box.everhelper.me/attachment/1743484/ol9gcxcw2043b3yo57hn/654956-0WeS6xOY3D1nic2S/screen.jpeg

Attachments (1)

4692.patch (3.8 KB) - added by milana_cap 5 years ago.

Download all attachments as: .zip

Change History (8)

@milana_cap
5 years ago

#1 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

This ticket was mentioned in Slack in #docs by zzap. View the logs.


5 years ago

This ticket was mentioned in Slack in #docs by zzap. View the logs.


5 years ago

This ticket was mentioned in Slack in #docs by zzap. View the logs.


5 years ago

This ticket was mentioned in Slack in #polyglots by tokyobiyori. View the logs.


5 years ago

#6 @coffee2code
5 years ago

In 9492:

Support Hub, ToC: Fix so markup for ToC subitems are nested under parent items instead of being their peer.

Props milana_cap.
See #4692.

#7 @coffee2code
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 9493:

Support Hub, ToC: Improve ToC styling.

Improves overall alignment and styling of list subitems.

Props milana_cap.
Fixes #4692.

Note: See TracTickets for help on using tickets.